Conversation
Enable fuzz_opt.py and clusterfuzz to use initial contents containing custom descriptors types and instructions and to generate new types that use custom descriptors. Enable custom descriptors when running V8. Do not yet allow the fuzzer to use initial contents containing br_on_cast_desc instructions, since V8 still has some bugs around those. Also do not yet generate new uses of custom descriptors instructions that were not present in the initial contents.
kripken
approved these changes
Aug 6, 2025
Member
Author
|
Although the tests passsed here, I noticed locally that the clusterfuzz python unit test could fail due to an unexpected number of execution failures. I added the custom descriptors flag to the V8 invocation in that test, so hopefully that solves the problem. |
Member
|
Makes sense. Maybe run it several times locally and see that the numbers look reasonable. Otherwise lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable fuzz_opt.py and clusterfuzz to use initial contents containing
custom descriptors types and instructions and to generate new types that
use custom descriptors. Enable custom descriptors when running V8.
Do not yet allow the fuzzer to use initial contents containing
br_on_cast_desc instructions, since V8 still has some bugs around those.
Also do not yet generate new uses of custom descriptors instructions
that were not present in the initial contents.