Allow JS and C to read the start function of a module#7424
Merged
kripken merged 6 commits intoWebAssembly:mainfrom Apr 2, 2025
GulgDev:patch-1
Merged
Allow JS and C to read the start function of a module#7424kripken merged 6 commits intoWebAssembly:mainfrom GulgDev:patch-1
kripken merged 6 commits intoWebAssembly:mainfrom
GulgDev:patch-1
Conversation
Add setStart function to JS wrapper
kripken
reviewed
Apr 1, 2025
Member
kripken
left a comment
There was a problem hiding this comment.
Code looks good. Please add a test in test/example/c-api-kitchen-sink.c.
Contributor
Author
|
@kripken Done! Added tests for C and JS. |
kripken
reviewed
Apr 2, 2025
Member
kripken
left a comment
There was a problem hiding this comment.
Looks good, but see the errors on CI. I think you need to add the declaration in the .h file alongside the .cpp
kripken
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
BinaryenGetStartto the C api and the correspondingmodule.getStartJS wrapper.