Conversation
Owner
Author
|
@gschaffner I'll upload a new release once this is over. All tests have passed and I have added a system to match uvloop although I think this bug was a mistake on the windows operating system's part and not ours. |
maj113
reviewed
Oct 19, 2025
| if system.PLATFORM_IS_WINDOWS: | ||
| # Winloop Comment: Winloop gets itself into trouble if this is | ||
| # is not checked immediately, it's too costly to call the python function | ||
| # bring in the flag instead to indicate colusre. |
Owner
Author
There was a problem hiding this comment.
@maj113 Should be fixed now, thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This new change helps us match more of uvloop's real functionallity like stopping a write(...) when a stream or transport is flagged as closing allowing us to easily capture invalid write(...) when close has already taken effect.
Are there changes in behavior for the user?
Uvloop and Winloop should now be fine-tuned with all major writing utilities (That goes for sockets as well)
Is it a substantial burden for the maintainers to support this?
Nope.
Related issue number
Fixes #84
Checklist