Use @turf/jsts, reduce bundle size#2217
Merged
JamesLMilner merged 2 commits intoTurfjs:masterfrom Oct 26, 2021
Merged
Conversation
47a35af to
918f415
Compare
twelch
approved these changes
Oct 23, 2021
Collaborator
twelch
left a comment
There was a problem hiding this comment.
Looks good. Nice work migrating.
4 tasks
d8dafaa to
07f085b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.This PR uses the new
@turf/jstspackage rather thanturf-jsts.You can see the difference in bundle sizes for those packages:
https://bundlephobia.com/package/@turf/jsts@2.7.1
https://bundlephobia.com/package/turf-jsts@1.2.3
Assuming you had a barebones build that used
@turf/bufferyou'd see the following improvements (around 18% decrease in bundle size):Before:
After: