Fix: overlapping italic / bold could case exception#34
Merged
Conversation
bb656c0 to
969e2f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take the string:
''a''' ''b'' zz'''c''Here the bold and italic are overlapping. The Bold part is:
''' ''b'' zz'''The Italic parts are:
''a''' ''and'' zz'''c''The problem here is that while replacing the first, the internal shadow variable of the last Italic part is no longer matching the actual string. The
zzgives just enough offset, that thematchon the last Italic object now returnsNone, instead of the actual match.This can be solved by first replacing the closing tag of the Bold with something that is of equal size than the closing string, so: three characters. That way the shadow of the Italic entries remain correct, and replacement works out fine.
In all of the cases we have seen this so far, it was always user-error for having unbalanced
', but that shouldn't cause a crash, ofc.