Skip to content

Update progress.py#3905

Merged
willmcgugan merged 4 commits intoTextualize:masterfrom
TomerYogev:extra-blank-line-on-disabled-progress
Jan 23, 2026
Merged

Update progress.py#3905
willmcgugan merged 4 commits intoTextualize:masterfrom
TomerYogev:extra-blank-line-on-disabled-progress

Conversation

@TomerYogev
Copy link
Contributor

Don't output extraneous blank line when progress display is disabled

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

AI?

  • AI was used to generate this PR

AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate (see note about typos above).
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

When creating a Progress with disabled=True, it still outputs a blank line on non interactive consoles. This PR adds an if not self.disable to the stop function, symmetrically to the start function.

Important: Link to an issue or discussion regarding these changes.

#110

TomerYogev and others added 3 commits December 3, 2025 23:32
Don't output extraneous blank line when progress display is disabled
@Domimueller85
Copy link

Don't output extraneous blank line when progress display is disabled

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

AI?

  • AI was used to generate this PR

AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate (see note about typos above).
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

When creating a Progress with disabled=True, it still outputs a blank line on non interactive consoles. This PR adds an if not self.disable to the stop function, symmetrically to the start function.

Important: Link to an issue or discussion regarding these changes.

#110

1 similar comment
@Domimueller85
Copy link

Don't output extraneous blank line when progress display is disabled

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

AI?

  • AI was used to generate this PR

AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate (see note about typos above).
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

When creating a Progress with disabled=True, it still outputs a blank line on non interactive consoles. This PR adds an if not self.disable to the stop function, symmetrically to the start function.

Important: Link to an issue or discussion regarding these changes.

#110

@willmcgugan
Copy link
Member

@Domimueller85 Let me know if your comments were some kind of mistake. If I don't hear from you, I intend to ban you from the repo.

Copy link
Member

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@willmcgugan willmcgugan merged commit fe55a13 into Textualize:master Jan 23, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants