Remove typing-extensions as a runtime dependency#3763
Remove typing-extensions as a runtime dependency#3763willmcgugan merged 7 commits intoTextualize:masterfrom
typing-extensions as a runtime dependency#3763Conversation
b1340e8 to
113bc1f
Compare
113bc1f to
3f5425e
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3763 +/- ##
==========================================
- Coverage 98.24% 97.97% -0.27%
==========================================
Files 74 74
Lines 8105 8118 +13
==========================================
- Hits 7963 7954 -9
- Misses 142 164 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
FWIW, I already filed a PR for this here and on pip's end: #3700 and pypa/pip#13336. |
|
🤦 forgot / missed this sorry. |
|
is there bandwith/plans for a release - as far as i understood pip can't vendor this fix without it being released |
|
FYI, this has already missed the pip 25.2 window, so any rich releases wouldn't be included until 25.3 (October), that is to say there's no rush. |
|
Also, this is not a fix. Just a small QoL improvement. Nothing will break if this isn't released promptly. |
Fixes #3762
Type of changes
Checklist
Description
Remove
typing-extensionsas a runtime dependency by:sys.version_info >= (3, 8)blocks as rich no longer supports Python 3.7typing_extensionsimport into aTYPE_CHECKINGblocktyping-extensionsfrom a runtime dependency to a dev dependency in thepyproject.tomlfileI did have some problems running pre-commit locally, hopefully that was just a local issue, I will fix any CI issues if they come up.