Skip to content

BUILD-6237 fix output when there are no artifacts to publish#249

Merged
julien-carsique-sonarsource merged 1 commit intomasterfrom
fix/jcarsique/BUILD-6237-noArtifactToPublish
Sep 10, 2024
Merged

BUILD-6237 fix output when there are no artifacts to publish#249
julien-carsique-sonarsource merged 1 commit intomasterfrom
fix/jcarsique/BUILD-6237-noArtifactToPublish

Conversation

@julien-carsique-sonarsource
Copy link
Copy Markdown
Contributor

@julien-carsique-sonarsource julien-carsique-sonarsource commented Sep 6, 2024 •
edited
Loading

"No artifacts to publish" was not printed because of get_property() defaulting to "" and not raising an exception, while get_module_property was raising an exception. Thus, the mistake in the implementation.

https://github.com/SonarSource/sonar-dummy/actions/runs/10787795372/job/29917197191 ✔️

Promoting sonar-dummy/5208 with {'status': 'released', 'sourceRepo': 'sonarsource-private-builds', 'targetRepo': 'sonarsource-private-releases'}
publishing artifacts for sonar-dummy#5208
No artifacts to publish

https://github.com/SonarSource/sonar-dummy-oss/actions/runs/10788084673/job/29918093951 ✔️

Promoting sonar-dummy-oss/5695 with {'status': 'released', 'sourceRepo': 'sonarsource-public-builds', 'targetRepo': 'sonarsource-public-releases'}
publishing artifacts for sonar-dummy-oss#5695
No artifacts to publish

@julien-carsique-sonarsource julien-carsique-sonarsource requested a review from a team as a code owner September 6, 2024 15:39
@julien-carsique-sonarsource julien-carsique-sonarsource force-pushed the fix/jcarsique/BUILD-6237-noArtifactToPublish branch 2 times, most recently from d95a2e5 to 3ad45a4 Compare September 6, 2024 16:46
@julien-carsique-sonarsource julien-carsique-sonarsource force-pushed the fix/jcarsique/BUILD-6237-noArtifactToPublish branch from 3ad45a4 to 3f1bc69 Compare September 9, 2024 16:36
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

This was referenced Sep 9, 2024
Merged
Closed
@julien-carsique-sonarsource julien-carsique-sonarsource deleted the fix/jcarsique/BUILD-6237-noArtifactToPublish branch September 10, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hedinasr hedinasr hedinasr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@julien-carsique-sonarsource @hedinasr