Skip to content

[py] Only skip WebKit tests on Windows #15470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cgoldberg merged 7 commits into from
Apr 5, 2025
Merged

[py] Only skip WebKit tests on Windows #15470

cgoldberg merged 7 commits into from
Apr 5, 2025

Conversation

@cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented Mar 21, 2025 •
edited by qodo-code-review bot
Loading

User description

Motivation and Context

This PR removes the restriction for running the internal Python tests for WebKit on certain platforms. Previously, tests would be skipped on any platform except Linux. However, WebKit is available on all xBSD systems as well as MacOS, so there is no reason to restrict tests from running on those. This change makes it so the WebKit tests are allowed to run on any platform besides Windows.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Bug fix, Tests

Description

  • Updated WebKit test skipping logic to exclude only Windows.

  • Removed unnecessary restriction for WebKit tests on non-Linux platforms.

  • Ensured compatibility for WebKit tests on xBSD and MacOS.

Changes walkthrough 📝

Relevant files
Tests
conftest.py
Adjust WebKit test skipping logic                                               

py/conftest.py

  • Modified WebKit test skipping condition to exclude only Windows.
  • Removed restriction for WebKit tests on non-Linux platforms.
    		• +2/-2     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Mar 21, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Mar 21, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @cgoldberg cgoldberg merged commit 702724c into SeleniumHQ:trunk Apr 5, 2025
    3 of 4 checks passed
    @cgoldberg cgoldberg deleted the py-tests-webkit-skip branch April 5, 2025 16:07
    @garrettgregor garrettgregor mentioned this pull request May 3, 2025
    Merged
    This was referenced Sep 12, 2025
    Closed
    Closed
    Merged
    This was referenced Sep 19, 2025
    Closed
    Closed
    Closed
    This was referenced Oct 1, 2025
    Closed
    Closed
    Closed
    @dependabot dependabot bot mentioned this pull request Oct 24, 2025
    Closed
    This was referenced Dec 21, 2025
    Open
    Open
    Open
    Open
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    Review effort 1/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    1 participant

    @cgoldberg