You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review
Access Control Changing field visibility from private to protected exposes internal implementation details. Verify that this change doesn't break encapsulation principles or expose sensitive command information to untrusted subclasses.
Restrict access modifier of a field to maintain proper encapsulation while preserving inheritance functionality
The client field is declared as public but should be protected since it's part of the internal implementation. Change its access modifier to protected to maintain encapsulation while still allowing subclass access.
-public final HttpClient client;+protected final HttpClient client;
Apply this suggestion
Suggestion importance[1-10]: 7
Why: The suggestion correctly identifies a potential encapsulation issue. Making the 'client' field protected instead of public aligns with good OOP practices by restricting access while still allowing inheritance functionality, similar to how other fields in the class are handled.
navin772
changed the title
[java]: change scope of additionalCommands to protected
[java]: encapsulate additionalCommands with getter method
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Solves #14811
Changed the scope of
additionalCommandsunderHttpCommandExecutortoprotectedTypes of changes
Checklist
PR Type
Bug fix
Description
additionalCommandsvariable in theHttpCommandExecutorclass fromprivatetoprotected.additionalCommandsmap.Changes walkthrough 📝
HttpCommandExecutor.java
Change scope of `additionalCommands` to `protected`java/src/org/openqa/selenium/remote/HttpCommandExecutor.java
additionalCommandsfromprivatetoprotected.additionalCommands.