You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As described in this comment, SpotBugs found some additional bugs in the code.
In this PR I fix part of the found problems.
SpotBugs error:
Executing tests from //java/src/org/openqa/selenium/firefox:firefox-lib-spotbugs
-----------------------------------------------------------------------------
M D NP: Possible null pointer dereference in org.openqa.selenium.firefox.AddHasExtensions$1.zipDirectory(Path) due to return value of called method Dereferenced at AddHasExtensions.java:[line 104]
Added a SpotBugs exclusion for the NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE bug pattern in the org.openqa.selenium.firefox.AddHasExtensions.* class.
This change prevents SpotBugs from reporting possible null pointer dereference issues in this class, aligning with existing exclusions for similar cases.
The update is part of efforts to fix issues before enabling full SpotBugs analysis to avoid build failures.
Changes walkthrough 📝
Relevant files
Bug fix
spotbugs-excludes.xml
Exclude null pointer dereference bug for AddHasExtensions
java/spotbugs-excludes.xml
Added exclusion for NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE bug pattern.
Applied exclusion to org.openqa.selenium.firefox.AddHasExtensions.* class.
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review
Technical Debt Suppressing SpotBugs warning instead of fixing the underlying null pointer issue. Consider addressing the root cause in AddHasExtensions class.
Use precise class pattern matching to avoid over-exclusion of SpotBugs checks
Consider using a more specific class pattern instead of wildcard (*) to avoid accidentally excluding unintended classes. Target only the specific inner class that needs the exclusion.
Why: The suggestion to use a more specific class pattern instead of wildcard is a good practice to prevent unintended exclusions of SpotBugs checks. However, without context about the specific inner classes involved, we can't be certain this won't exclude necessary cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
As described in this comment, SpotBugs found some additional bugs in the code.
In this PR I fix part of the found problems.
SpotBugs error:
documentation
Solution:
Exclude this anonymous class from SpotBugs checks. A similar exclusion already exists for
org.openqa.selenium.grid.config.Configs.Motivation and Context
Fixing the actual problems is necessary before enabling full SpotBugs analysis, in order to not break the build.
Types of changes
Checklist
PR Type
Bug fix
Description
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUEbug pattern in theorg.openqa.selenium.firefox.AddHasExtensions.*class.Changes walkthrough 📝
spotbugs-excludes.xml
Exclude null pointer dereference bug for AddHasExtensionsjava/spotbugs-excludes.xml
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUEbugpattern.
org.openqa.selenium.firefox.AddHasExtensions.*class.