Skip to content

[java] deleted the deprecated FormEncodedData#14688

Merged
pujagani merged 1 commit intotrunkfrom
FormEncodedData
Nov 6, 2024
Merged

[java] deleted the deprecated FormEncodedData#14688
pujagani merged 1 commit intotrunkfrom
FormEncodedData

Conversation

@joerg1985
Copy link
Copy Markdown
Member

@joerg1985 joerg1985 commented Oct 30, 2024 •
edited by qodo-code-review Bot
Loading

User description

Description

This PR will delete the deprecated FormEncodedData and the related unittests.
I assume this has not been used for years, so this can be removed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement, Tests

Description

  • Removed the deprecated FormEncodedData class from the codebase, which was marked for removal.
  • Deleted all associated unit tests for the FormEncodedData class, which tested form-encoded data handling.

Changes walkthrough 📝

Relevant files
Enhancement
FormEncodedData.java
Remove deprecated `FormEncodedData` class                               

java/src/org/openqa/selenium/remote/http/FormEncodedData.java

  • Removed the entire FormEncodedData class.
  • The class was marked as deprecated for removal.
    		•  +0/-95   
    Tests
    FormEncodedDataTest.java
    Remove tests for deprecated `FormEncodedData` class           

    java/test/org/openqa/selenium/remote/http/FormEncodedDataTest.java

  • Deleted all unit tests related to FormEncodedData.
  • Tests covered various scenarios for form-encoded data handling.
    		•  +0/-150 

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @qodo-code-review
    Copy link
    Copy Markdown
    Contributor

    qodo-code-review Bot commented Oct 30, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Deprecation Removal
    Verify that the removal of FormEncodedData does not break any existing functionality or dependencies in the project.

    Test Removal
    Ensure that the removal of FormEncodedDataTest does not leave any gaps in test coverage for related functionality.

    @qodo-code-review
    Copy link
    Copy Markdown
    Contributor

    qodo-code-review Bot commented Oct 30, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @joerg1985
    Copy link
    Copy Markdown
    Member Author

    joerg1985 commented Oct 30, 2024

    /help "In what year has the FormEncodedData been used the last time, beside unit tests?"

    @qodo-code-review
    Copy link
    Copy Markdown
    Contributor

    qodo-code-review Bot commented Oct 30, 2024

    Question:

    In what year has the FormEncodedData been used the last time, beside unit tests?

    Answer:

    Based on the provided documentation, there is no specific information about when FormEncodedData was last used outside of unit tests. The documentation does not contain any references to FormEncodedData or its usage history. To accurately answer this question, we would need access to the project's codebase and commit history, which is not available in the given documentation.

    Relevant Sources:

    @pujagani
    Copy link
    Copy Markdown
    Contributor

    pujagani commented Nov 6, 2024

    I think this should be fine to remove. Thank you @joerg1985!

    @pujagani pujagani merged commit 7dc68df into trunk Nov 6, 2024
    @pujagani pujagani deleted the FormEncodedData branch November 6, 2024 11:24
    @dependabot dependabot Bot mentioned this pull request Sep 18, 2025
    Merged
    @dependabot dependabot Bot mentioned this pull request Oct 1, 2025
    Closed
    @dependabot dependabot Bot mentioned this pull request Oct 24, 2025
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @pujagani pujagani pujagani approved these changes

    Assignees

    No one assigned

    Labels

    Review effort [1-5]: 1

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @joerg1985 @pujagani