Skip to content

[py] Added Deprecation of WebElement.get_attribute() per #13334#14675

Merged
AutomatedTester merged 6 commits intoSeleniumHQ:trunkfrom
shbenzer:get_attribute-deprecated-py
Nov 3, 2024
Merged

[py] Added Deprecation of WebElement.get_attribute() per #13334#14675
AutomatedTester merged 6 commits intoSeleniumHQ:trunkfrom
shbenzer:get_attribute-deprecated-py

Conversation

@shbenzer
Copy link
Copy Markdown
Contributor

@shbenzer shbenzer commented Oct 29, 2024 •
edited by qodo-code-review Bot
Loading

User description

Description

added deprecation warning to WebElement.get_attribute()

Motivation and Context

#13334

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

enhancement, documentation

Description

  • Added a deprecation warning to the WebElement.get_attribute() method in the Selenium WebDriver Python library.
  • Users are advised to use the get_dom_attribute() method instead.
  • This change addresses issue [🚀 Feature]: deprecate WebElement.getAttribute #13334 and aims to guide users towards more modern practices.

PRDescriptionHeader.CHANGES_WALKTHROUGH

Relevant files
Enhancement
webelement.py
Deprecate `WebElement.get_attribute()` method with warning

py/selenium/webdriver/remote/webelement.py

  • Added a deprecation warning for WebElement.get_attribute().
  • Suggested using get_dom_attribute() instead.
    		•  +7/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @qodo-code-review
    Copy link
    Copy Markdown
    Contributor

    qodo-code-review Bot commented Oct 29, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Deprecation Warning
    The deprecation warning message is missing a comma after the warning text, which may cause a syntax error.

    @qodo-code-review
    Copy link
    Copy Markdown
    Contributor

    qodo-code-review Bot commented Oct 29, 2024 •
    edited
    Loading

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible bug
    ✅ Fix syntax error in warning message by adding a missing comma
    Suggestion Impact:The suggestion was implemented by adding the missing comma after the warning message string in the warnings.warn() call.

    code diff:

    -            "using WebElement.get_attribute() has been deprecated. Please use get_dom_attribute() instead."
+            "using WebElement.get_attribute() has been deprecated. Please use get_dom_attribute() instead.",

    Add the missing comma after the warning message string in the warnings.warn() call
    to fix the syntax error.

    py/selenium/webdriver/remote/webelement.py [177-181]

     warnings.warn(
-    "using WebElement.get_attribute() has been deprecated. Please use get_dom_attribute() instead."
+    "using WebElement.get_attribute() has been deprecated. Please use get_dom_attribute() instead.",
     DeprecationWarning,
     stacklevel=2,
 )
    • Apply this suggestion
    Suggestion importance[1-10]: 10

    Why: The suggestion correctly identifies a syntax error due to a missing comma in the warnings.warn() call, which is crucial for the code to function properly. Adding the comma is necessary to avoid runtime errors, making this a high-impact fix.

    		10

    💡 Need additional feedback ? start a PR chat

    @VietND96 VietND96 added the C-py Python Bindings label Nov 1, 2024
    @shbenzer
    Copy link
    Copy Markdown
    Contributor Author

    shbenzer commented Nov 1, 2024

    @VietND96 Failing test is unrelated

    @shbenzer
    Copy link
    Copy Markdown
    Contributor Author

    shbenzer commented Nov 1, 2024

    Just pushed a fix for that flaky test actually #14701

    @shbenzer
    Copy link
    Copy Markdown
    Contributor Author

    shbenzer commented Nov 3, 2024

    @VietND96 now that the bidi_tests.py fix has been merged, could you run the ci workflow again?

    @AutomatedTester AutomatedTester merged commit bb3053b into SeleniumHQ:trunk Nov 3, 2024
    VietND96 added a commit that referenced this pull request Nov 26, 2024
    @VietND96
    Revert "[py] Added Deprecation of WebElement.get_attribute() per #13334…
    6625a6b 
    … (#14675)"

This reverts commit bb3053b.
    diemol pushed a commit that referenced this pull request Nov 26, 2024
    @VietND96
    [py] Revert the Deprecation warnings of WebElement.get_attribute() (#…
    1210634 
    …14808)

Revert "[py] Added Deprecation of WebElement.get_attribute() per #13334 (#14675)"

This reverts commit bb3053b.
    @shbenzer shbenzer deleted the get_attribute-deprecated-py branch January 16, 2025 00:38
    @dependabot dependabot Bot mentioned this pull request Sep 18, 2025
    Merged
    @dependabot dependabot Bot mentioned this pull request Oct 1, 2025
    Closed
    @dependabot dependabot Bot mentioned this pull request Oct 24, 2025
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @AutomatedTester AutomatedTester AutomatedTester approved these changes

    Assignees

    No one assigned

    Labels

    C-py Python Bindings Review effort [1-5]: 2

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @shbenzer @AutomatedTester @VietND96