Skip to content

[ci] [dotnet] Enable long path in bazel #14634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nvborisenko merged 1 commit into from
Oct 22, 2024
Merged

[ci] [dotnet] Enable long path in bazel #14634

nvborisenko merged 1 commit into from
Oct 22, 2024

Conversation

@nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Oct 22, 2024 •
edited by qodo-code-review bot
Loading

User description

Description

This is a continuation of 6ea5651#diff-6097d5fb92c6d1746b67c0e66c6d66f2f4b2e848d5fae5de189f7112e58da9cfR25 to make CI green for dotnet workflow.

Motivation and Context

CI is green?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

configuration changes

Description

  • Added a command in the CI workflow to disable 8dot3name creation on Windows, which supports long file paths in Bazel.
  • This change is aimed at ensuring the CI process for the dotnet workflow runs smoothly without path length issues.

Changes walkthrough 📝

Relevant files
Configuration changes
ci-dotnet.yml
Disable 8dot3name creation for long path support in Bazel

.github/workflows/ci-dotnet.yml

  • Added command to disable 8dot3name creation on Windows.
  • Ensures compatibility with long file paths in Bazel.
    		•  +1/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Oct 22, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Change
    The addition of the 'fsutil 8dot3name set 0' command disables 8.3 filename creation on Windows. This change should be validated to ensure it doesn't negatively impact other parts of the CI process or local development environments.

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Oct 22, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @nvborisenko
    Copy link
    Member Author

    nvborisenko commented Oct 22, 2024

    Very good, CI check is green.

    @nvborisenko nvborisenko merged commit 029d263 into SeleniumHQ:trunk Oct 22, 2024
    @nvborisenko nvborisenko deleted the ci-dotnet-long-path branch October 22, 2024 19:48
    @dependabot dependabot bot mentioned this pull request Sep 18, 2025
    Merged
    @dependabot dependabot bot mentioned this pull request Oct 1, 2025
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    Review effort [1-5]: 1

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    1 participant

    @nvborisenko