[build] update rules_dotnet to 0.15.1 by titusfortner · Pull Request #14096 · SeleniumHQ/selenium

titusfortner · 2024-06-06T21:47:12Z

User description

working locally need to check if it builds and runs on RBE

PR Type

enhancement, configuration changes

Description

Updated the rules_dotnet dependency version from 0.14.0 to 0.15.1 in MODULE.bazel.
Modified the bazel run command in dotnet/update-deps.sh to remove the .exe extension.
Updated the generated comment header in dotnet/paket.nuget_extension.bzl.

Changes walkthrough 📝

Relevant files

Enhancement

paket.nuget_extension.bzl `Update generated comment header in paket.nuget_extension.bzl` dotnet/paket.nuget_extension.bzl Modified the generated comment header.	+1/-1
update-deps.sh `Modify bazel run command in update-deps.sh` dotnet/update-deps.sh Updated the `bazel run` command to remove `.exe` extension.	+1/-1

Configuration changes

MODULE.bazel `Update rules_dotnet dependency version in MODULE.bazel` MODULE.bazel Updated `rules_dotnet` dependency version from 0.14.0 to 0.15.1.	+1/-1

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

qodo-code-review · 2024-06-06T21:47:37Z

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are straightforward and involve simple updates to dependency versions and script modifications. The PR is small and the context of the changes is clear, which should make the review process relatively quick and easy.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The removal of the `.exe` extension in the `update-deps.sh` script could potentially cause issues if the environment where the script is run expects the `.exe` extension for execution. This should be tested in the target environment to ensure compatibility.
🔒 Security concerns	No

qodo-code-review · 2024-06-06T21:48:23Z

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Add error handling for the `bazel run` command to ensure failures are reported and handled Add error handling for the `bazel run` command to ensure that any failure in this step is properly reported and handled. dotnet/update-deps.sh [8] -bazel run @rules_dotnet//tools/paket2bazel:paket2bazel -- --dependencies-file "$(pwd)"/paket.dependencies --output-folder "$(pwd)" +if ! bazel run @rules_dotnet//tools/paket2bazel:paket2bazel -- --dependencies-file "$(pwd)"/paket.dependencies --output-folder "$(pwd)"; then + echo "Error: Bazel run failed" + exit 1 +fi Apply this suggestion Suggestion importance[1-10]: 8 Why: This suggestion is crucial as it adds error handling to a script command, which is important for robustness and reliability of the deployment process.	8
Maintainability	Break down long dictionary definitions into multiple lines for better readability and maintainability Consider breaking down the long dictionary definitions for each package into multiple lines for better readability and maintainability. This will make it easier to spot errors and understand the structure of each package's dependencies. dotnet/paket.nuget.bzl [10] -{"name": "BenderProxy", "id": "BenderProxy", "version": "1.0.0", "sha512": "sha512-zNsAtO6ZwNa0MfyFFJAzA6rsTtqnjY+bD2gCDHSUIbRS31wRJ9GfOeummSlEVaH/DSxxiuQaIhZmtIFAM0WW+A==", "sources": ["https://api.nuget.org/v3/index.json"], "dependencies": {"net11": [], "net20": [], "net30": [], "net35": [], "net40": [], "net403": [], "net45": [], "net451": [], "net452": [], "net46": [], "net461": [], "net462": [], "net47": [], "net471": [], "net472": [], "net48": [], "net5.0": [], "net6.0": [], "net7.0": [], "net8.0": [], "netcoreapp1.0": [], "netcoreapp1.1": [], "netcoreapp2.0": [], "netcoreapp2.1": [], "netcoreapp2.2": [], "netcoreapp3.0": [], "netcoreapp3.1": [], "netstandard": [], "netstandard1.0": [], "netstandard1.1": [], "netstandard1.2": [], "netstandard1.3": [], "netstandard1.4": [], "netstandard1.5": [], "netstandard1.6": [], "netstandard2.0": [], "netstandard2.1": []}, "targeting_pack_overrides": [], "framework_list": []} +{ + "name": "BenderProxy", + "id": "BenderProxy", + "version": "1.0.0", + "sha512": "sha512-zNsAtO6ZwNa0MfyFFJAzA6rsTtqnjY+bD2gCDHSUIbRS31wRJ9GfOeummSlEVaH/DSxxiuQaIhZmtIFAM0WW+A==", + "sources": ["https://api.nuget.org/v3/index.json"], + "dependencies": { + "net11": [], + "net20": [], + "net30": [], + "net35": [], + "net40": [], + "net403": [], + "net45": [], + "net451": [], + "net452": [], + "net46": [], + "net461": [], + "net462": [], + "net47": [], + "net471": [], + "net472": [], + "net48": [], + "net5.0": [], + "net6.0": [], + "net7.0": [], + "net8.0": [], + "netcoreapp1.0": [], + "netcoreapp1.1": [], + "netcoreapp2.0": [], + "netcoreapp2.1": [], + "netcoreapp2.2": [], + "netcoreapp3.0": [], + "netcoreapp3.1": [], + "netstandard": [], + "netstandard1.0": [], + "netstandard1.1": [], + "netstandard1.2": [], + "netstandard1.3": [], + "netstandard1.4": [], + "netstandard1.5": [], + "netstandard1.6": [], + "netstandard2.0": [], + "netstandard2.1": [] + }, + "targeting_pack_overrides": [], + "framework_list": [] +} Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion correctly identifies a maintainability improvement by breaking down long dictionary definitions into multiple lines, which enhances readability and error spotting.	7
Best practice	Use a consistent format for the generated file marker across different files Use a consistent format for the generated file marker to match the format used in `dotnet/paket.nuget.bzl` for consistency across files. dotnet/paket.nuget_extension.bzl [1] -"Generated" +"GENERATED" Apply this suggestion Suggestion importance[1-10]: 6 Why: Ensuring consistency in file markers across related files is a good practice for maintainability and readability, although it's a relatively minor issue.	6
Best practice	Ensure all dependencies are updated to their latest stable versions Ensure that the version numbers for all dependencies are updated to the latest stable versions to avoid potential compatibility issues. MODULE.bazel [13] bazel_dep(name = "rules_dotnet", version = "0.15.1") +# Ensure all dependencies are updated to their latest stable versions Apply this suggestion Suggestion importance[1-10]: 5 Why: The suggestion to update dependencies is generally good practice, but it lacks specific actionable changes and does not provide evidence that the current versions are outdated.	5

qodo-code-review · 2024-06-06T22:08:10Z

CI Failure Feedback 🧐

(Checks updated until commit `b7a9b94`)

Action: .NET / Browser Tests / Browser Tests
Failed stage: Run Bazel [❌]
Failed test name: //dotnet/test/common:ElementFindingTest-chrome
Failure summary: The action failed due to the following reasons: The `protoc.exe` command failed to execute successfully, causing a build error. Specifically, the error occurred while generating the `proto_library` for the target `@io_bazel_rules_closure//java/io/bazel/rules/closure:build_info_proto`. The error message indicates an `Exit -1073741819` status, which is a generic Windows error code indicating an application crash. As a result, the build did not complete successfully, and the test `//dotnet/test/common:ElementFindingTest-chrome` failed to build.
Relevant error logs: 1: ##[group]Operating System 2: Microsoft Windows Server 2022 ... 574: �[32m[1 / 1]�[0m checking cached actions 575: �[32mAnalyzing:�[0m 2 targets (502 packages loaded, 21237 targets configured) 576: �[32m[1 / 1]�[0m checking cached actions 577: �[32mAnalyzing:�[0m 2 targets (508 packages loaded, 24021 targets configured) 578: �[32m[1 / 1]�[0m checking cached actions 579: �[32mINFO: �[0mAnalyzed 2 targets (508 packages loaded, 24083 targets configured). 580: �[32m[216 / 1,522]�[0m Creating source manifest for //common/devtools:pdl_to_json [for tool]; 0s local 581: �[32m[804 / 2,104]�[0m Copying files; 0s local ... (2 actions, 1 running) 582: �[32m[834 / 2,104]�[0m Executing genrule @@rules_jvm_external~~maven~maven//:dev_failsafe_failsafe_3_3_2_extension; 0s local ... 685: �[32m[1,096 / 2,104]�[0m Compiling runfiles; 13s local ... (4 actions, 3 running) 686: �[32m[1,097 / 2,104]�[0m Compiling runfiles; 14s local ... (4 actions running) 687: �[32m[1,099 / 2,104]�[0m Compiling runfiles; 15s local ... (4 actions running) 688: �[32m[1,105 / 2,104]�[0m Compiling runfiles; 16s local ... (4 actions running) 689: �[32m[1,108 / 2,104]�[0m Compiling runfiles; 18s local ... (4 actions, 3 running) 690: �[32m[1,112 / 2,104]�[0m Compiling runfiles; 19s local ... (4 actions running) 691: �[32m[1,117 / 2,104]�[0m Compiling runfiles; 20s local ... (4 actions running) 692: �[32m[1,119 / 2,104]�[0m Compiling runfiles; 21s local ... (4 actions running) 693: �[31m�[1mERROR: �[0mD:/_bazel/external/io_bazel_rules_closure/java/io/bazel/rules/closure/BUILD:64:14: Generating proto_library @@io_bazel_rules_closure//java/io/bazel/rules/closure:build_info_proto [for tool] failed: (Exit -1073741819): protoc.exe failed: error executing GenProto command (from target @@io_bazel_rules_closure//java/io/bazel/rules/closure:build_info_proto) 694: cd /d D:/_bazel/execroot/_main 695: SET PATH=C:\Program Files\Git\bin;C:\Program Files\Git\usr\bin;C:\Windows;C:\Windows\System32;C:\Windows\System32\WindowsPowerShell\v1.0 696: bazel-out\x64_windows-opt-exec-ST-4eedf4a3b688\bin\external\protobuf~\protoc.exe --java_out=bazel-out/x64_windows-opt-exec-ST-4eedf4a3b688/bin/external/io_bazel_rules_closure/java/io/bazel/rules/closure/build_info_proto-speed-src.jar -Iexternal/io_bazel_rules_closure -I. external/io_bazel_rules_closure/java/io/bazel/rules/closure/build_info.proto 697: # Configuration: c4c5b213685058484698870969db21c43c1827cd924f94ca91a1e5ef606ef2ca 698: # Execution platform: @@local_config_platform//:host 699: �[32m[1,126 / 2,104]�[0m 1 / 2 tests, �[31m�[1m1 failed�[0m;�[0m checking cached actions 700: �[32mINFO: �[0mElapsed time: 290.937s, Critical Path: 33.34s 701: �[32mINFO: �[0m1126 processes: 820 internal, 293 local, 13 worker. 702: �[31m�[1mERROR: �[0mBuild did NOT complete successfully 703: //dotnet/test/common:ElementFindingTest-firefox �[0m�[31m�[1mNO STATUS�[0m 704: //dotnet/test/common:ElementFindingTest-chrome �[0m�[31m�[1mFAILED TO BUILD�[0m 705: Executed 0 out of 2 tests: �[0m�[31m�[1m1 fails to build�[0m and �[0m�[35m1 was skipped�[0m. 706: �[0m 707: ##[error]Process completed with exit code 1. 708: Post job cleanup. 709: ##[group]Save cache for repository 710: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 711: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-repository-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-repository-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: 2db72f5dfd1720e8486e342cff652f17e6342fbba8f9d194b436469eb88c04d2 712: Successfully saved cache 713: ##[endgroup] 714: ##[group]Save cache for external-aspect_rules_js~~pnpm~pnpm 715: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 716: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-aspect_rules_js~~pnpm~pnpm-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-aspect_rules_js~~pnpm~pnpm-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: a6a35d22b00bfb86962131516cc300dd2fde0da67aa6c588c38783f2357ee83b 717: Successfully saved cache 718: ##[endgroup] 719: ##[group]Save cache for external-com_github_protocolbuffers_protobuf 720: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 721: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-com_github_protocolbuffers_protobuf-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-com_github_protocolbuffers_protobuf-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: e95d5d8413efdc8ba6189a1cb1148716e333c6d1c4300b223a9480c5d9e0e775 722: Successfully saved cache 723: ##[endgroup] 724: ##[group]Save cache for external-com_google_javascript_closure_library 725: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 726: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-com_google_javascript_closure_library-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-com_google_javascript_closure_library-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: 37ed15960e449c74868a3d26f904247df68f8aa0152735c69b1bc7ec9e0929d2 727: Successfully saved cache 728: ##[endgroup] 729: ##[group]Save cache for external-protobuf~ 730: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 731: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-protobuf~-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-protobuf~-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: eb62465ec7f84ce1b519af65cc02cc5e0eb97a77656d8a23aad2b9cb2e4059d7 732: Successfully saved cache 733: ##[endgroup] 734: ##[group]Save cache for external-rules_dotnet~~apphost_packs_extension~nuget.microsoft.netcore.app.host.win-x64.v7.0.17 735: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 736: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-rules_dotnet~~apphost_packs_extension~nuget.microsoft.netcore.app.host.win-x64.v7.0.17-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-rules_dotnet~~apphost_packs_extension~nuget.microsoft.netcore.app.host.win-x64.v7.0.17-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: 3e4fe90b1fec7a7af178991dadff839489e602681cdfb383dd4749705af27335 737: Successfully saved cache 738: ##[endgroup] 739: ##[group]Save cache for external-rules_dotnet~~dotnet~dotnet_x86_64-pc-windows-msvc 740: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 741: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-rules_dotnet~~dotnet~dotnet_x86_64-pc-windows-msvc-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-rules_dotnet~~dotnet~dotnet_x86_64-pc-windows-msvc-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: 8587614581ea9c89c75801cb6d8ef60240fda598780ce8d514a592322b2a13f8 742: Successfully saved cache 743: ##[endgroup] 744: ##[group]Save cache for external-rules_dotnet~~rules_dotnet_nuget_packages_extension~nuget.microsoft.netcore.app.ref.v6.0.5 745: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 746: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-rules_dotnet~~rules_dotnet_nuget_packages_extension~nuget.microsoft.netcore.app.ref.v6.0.5-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-rules_dotnet~~rules_dotnet_nuget_packages_extension~nuget.microsoft.netcore.app.ref.v6.0.5-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: 0846cad85768974f8967838cb2c8855fc3c5df83208cff9fb4522dde3d93120d 747: Successfully saved cache 748: ##[endgroup] 749: ##[group]Save cache for external-rules_dotnet~~runtime_packs_extension~nuget.microsoft.netcore.app.runtime.win-x64.v7.0.17 750: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 751: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-rules_dotnet~~runtime_packs_extension~nuget.microsoft.netcore.app.runtime.win-x64.v7.0.17-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-rules_dotnet~~runtime_packs_extension~nuget.microsoft.netcore.app.runtime.win-x64.v7.0.17-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: d206eed00dbde092f4edafa557c101fedd3a2ae49ff51a2b2b4d0c5421743899 752: Successfully saved cache 753: ##[endgroup] 754: ##[group]Save cache for external-rules_dotnet~~targeting_packs_extension~nuget.microsoft.netcore.app.ref.v7.0.17 755: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 756: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-rules_dotnet~~targeting_packs_extension~nuget.microsoft.netcore.app.ref.v7.0.17-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-rules_dotnet~~targeting_packs_extension~nuget.microsoft.netcore.app.ref.v7.0.17-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: 6d8036e0e49cbed08a4401ae3ccd56185fff4b55d3a30b4cebe569a2a570a5ba 757: Successfully saved cache 758: ##[endgroup] 759: ##[group]Save cache for external-rules_dotnet~~targeting_packs_extension~nuget.netstandard.library.v2.0.3 760: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 761: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-rules_dotnet~~targeting_packs_extension~nuget.netstandard.library.v2.0.3-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-rules_dotnet~~targeting_packs_extension~nuget.netstandard.library.v2.0.3-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: a9c971170d1189e5c3f6238b71aaae4e8e649e08e9c8f82fbfaf5f0bc53492c3 762: Successfully saved cache 763: ##[endgroup] 764: ##[group]Save cache for external-rules_java~~toolchains~remotejdk17_win 765: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 766: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-rules_java~~toolchains~remotejdk17_win-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-rules_java~~toolchains~remotejdk17_win-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: 78e423082a50fbe22e96560aa2307c72fe018aa4c939b61d81985f8f30de0716 ... 769: ##[group]Save cache for external-rules_java~~toolchains~remotejdk21_win 770: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 771: Cache Size: ~185 MB (193537710 B) 772: Cache saved successfully 773: Successfully saved cache 774: ##[endgroup] 775: ##[group]Save cache for external-rules_java~~toolchains~remote_java_tools 776: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 777: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-rules_java~~toolchains~remote_java_tools-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-rules_java~~toolchains~remote_java_tools-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: 057ab10c1bbeac9e00a3e0e722798b5e070f8b8820cb84b0cc60f99bb89a1809 ... 786: ##[group]Save cache for external-rules_kotlin~ 787: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 788: Cache Size: ~19 MB (19523291 B) 789: Cache saved successfully 790: Successfully saved cache 791: ##[endgroup] 792: ##[group]Save cache for external-rules_kotlin~~rules_kotlin_extensions~com_github_jetbrains_kotlin 793: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 794: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-rules_kotlin~~rules_kotlin_extensions~com_github_jetbrains_kotlin-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-rules_kotlin~~rules_kotlin_extensions~com_github_jetbrains_kotlin-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: fdfa52d32e5910ccc4cfa6dfab7cc4b5a3c92b9416e2c6722ece2c8ecf1fd572 ... 809: ##[group]Save cache for external-rust_windows_x86_64__x86_64-pc-windows-msvc__stable_tools 810: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 811: Cache Size: ~194 MB (203911945 B) 812: Cache saved successfully 813: Successfully saved cache 814: ##[endgroup] 815: ##[group]Save cache for external-_main~nuget_extension~nuget.microsoft.netcore.app.ref.v6.0.9 816: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 817: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-_main~nuget_extension~nuget.microsoft.netcore.app.ref.v6.0.9-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-_main~nuget_extension~nuget.microsoft.netcore.app.ref.v6.0.9-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: ebb5d12326040bef5461a122735d97ca79bb3ef51846f211bb82a427fd2f1080 818: Successfully saved cache 819: ##[endgroup] 820: ##[group]Save cache for external-_main~nuget_extension~nuget.netstandard.library.v2.0.3 821: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 822: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-_main~nuget_extension~nuget.netstandard.library.v2.0.3-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-_main~nuget_extension~nuget.netstandard.library.v2.0.3-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: b022d74886066918a0cbe440ef1825b4f66fe7e4e38f9bad5872b3f7b655859c 823: Successfully saved cache 824: ##[endgroup] 825: ##[group]Save cache for external-_main~nuget_extension~nuget.newtonsoft.json.v13.0.1 826: [command]"C:\Program Files\Git\usr\bin\tar.exe" --posix -cf cache.tzst --exclude cache.tzst -P -C D:/a/selenium/selenium --files-from manifest.txt --force-local --use-compress-program "zstd -T0" 827: Failed to save: Unable to reserve cache with key setup-bazel-2-win32-external-_main~nuget_extension~nuget.newtonsoft.json.v13.0.1-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/14096/merge, Key: setup-bazel-2-win32-external-_main~nuget_extension~nuget.newtonsoft.json.v13.0.1-2c5d427ca5f44c37430975320bd991be3f6bd4b392a266db98dcecda9df55899, Version: b630864d6260e7cbb23bec225e5446f190e64852547a1f48e8adbdfe389d65d6

✨ CI feedback usage guide:

The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:

Failed stage
Failed test name
Failure summary
Relevant error logs

In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

Configuration options

enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

See more information about the checks tool in the docs.

[build] update rules_dotnet to 0.15.1

b7a9b94

titusfortner added C-dotnet .NET Bindings B-build Includes scripting, bazel and CI integrations labels Jun 6, 2024

qodo-code-review bot added P-enhancement PR with a new feature configuration changes labels Jun 6, 2024

qodo-code-review bot added the Review effort [1-5]: 2 label Jun 6, 2024

titusfortner merged commit c6e898a into trunk Jun 7, 2024

titusfortner deleted the rules_dotnet branch June 7, 2024 13:11

seedysoft mentioned this pull request Jun 21, 2024

Bump Selenium.WebDriver from 4.21.0 to 4.22.0 seedysoft/all-my-stuff#53

Merged

MiguelPelegrina mentioned this pull request Jul 12, 2024

[Snyk] Upgrade selenium-webdriver from 4.21.0 to 4.22.0 MiguelPelegrina/java_school_online_store_frontend#19

Merged

aravindb26 mentioned this pull request Jul 16, 2024

[Snyk] Upgrade selenium-webdriver from 4.16.0 to 4.22.0 aravindb26/spark#3

Open

x-way mentioned this pull request Jul 24, 2024

[Snyk] Upgrade selenium-webdriver from 4.18.1 to 4.22.0 x-way/cal-heatmap#503

Closed

x-way mentioned this pull request Aug 10, 2024

[Snyk] Upgrade selenium-webdriver from 4.18.1 to 4.23.0 x-way/cal-heatmap#544

Closed

sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Oct 29, 2024

[build] update rules_dotnet to 0.15.1 (SeleniumHQ#14096)

8d26ed8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[build] update rules_dotnet to 0.15.1#14096

[build] update rules_dotnet to 0.15.1#14096
titusfortner merged 1 commit intotrunkfrom
rules_dotnet

titusfortner commented Jun 6, 2024 •

edited by qodo-code-review bot

Loading

Uh oh!

qodo-code-review bot commented Jun 6, 2024

Uh oh!

qodo-code-review bot commented Jun 6, 2024

Uh oh!

qodo-code-review bot commented Jun 6, 2024 •

edited

Loading

Configuration options

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

titusfortner commented Jun 6, 2024 • edited by qodo-code-review bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

PR Type

Description

Changes walkthrough 📝

Uh oh!

qodo-code-review bot commented Jun 6, 2024

PR Review 🔍

Uh oh!

qodo-code-review bot commented Jun 6, 2024

PR Code Suggestions ✨

Uh oh!

qodo-code-review bot commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Failure Feedback 🧐

(Checks updated until commit b7a9b94)

Configuration options

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

titusfortner commented Jun 6, 2024 •

edited by qodo-code-review bot

Loading

qodo-code-review bot commented Jun 6, 2024 •

edited

Loading

(Checks updated until commit `b7a9b94`)