[py] Update test to check it's an integer rather than a value#17114
Merged
AutomatedTester merged 1 commit intotrunkfrom Feb 19, 2026
Merged
[py] Update test to check it's an integer rather than a value#17114AutomatedTester merged 1 commit intotrunkfrom
AutomatedTester merged 1 commit intotrunkfrom
Conversation
On 2nd monitors if tests run on the secondary monitor and it is left of the primary monitor x and y will return negative which is allowed. This will also handle tests running on a different desktop which is supported but undefined in the spec
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a test for window coordinate validation to properly handle multi-monitor setups. The change modifies assertions for x and y coordinates from range checks (>= 0) to type checks (isinstance(..., int)), since window coordinates can be negative when windows are positioned on secondary monitors left of or above the primary monitor.
Changes:
- Updated
test_get_client_windowsto validate x and y coordinates are integers rather than non-negative values
navin772
approved these changes
Feb 19, 2026
cgoldberg
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 2nd monitors if tests run on the secondary monitor and it is left of the primary monitor x and y will return negative which is allowed. This will also handle tests running on a different desktop which is supported but undefined in the spec
🔗 Related Issues
💥 What does this PR do?
Fixes a test
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes