[java] Self-signed certificate should not require certificate file#13268
Merged
pujagani merged 1 commit intoSeleniumHQ:trunkfrom Dec 8, 2023
Merged
[java] Self-signed certificate should not require certificate file#13268pujagani merged 1 commit intoSeleniumHQ:trunkfrom
pujagani merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13268 +/- ##
==========================================
+ Coverage 57.53% 57.95% +0.42%
==========================================
Files 86 88 +2
Lines 5310 5333 +23
Branches 221 224 +3
==========================================
+ Hits 3055 3091 +36
+ Misses 2034 2018 -16
- Partials 221 224 +3 ☔ View full report in Codecov by Sentry. |
diemol
approved these changes
Dec 8, 2023
Member
Contributor
Author
|
Sure! Will do that. Appreciate your help! Thank you |
Member
Member
|
Not really, is this urgent and needs a patch release? |
Member
I think not urgent, we can wait for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
When using Grid with
--self-signed-httpsoption, it throws an error that "You must provide a certificate via --https-certificate when using --https". It is not required when using self-signed. The error occurred during the check at the stephttps://github.com/SeleniumHQ/selenium/blob/trunk/java/src/org/openqa/selenium/grid/security/SecretOptions.java#L44.
The easiest solution was to remove the check however that might not be the right solution since I do not have the context of why it was added here and if/why registration secret is required for this case too.
Motivation and Context
Types of changes
Checklist