[dotnet] Change a list of downloadable files to IReadOnlyList#13265
Merged
titusfortner merged 2 commits intoSeleniumHQ:trunkfrom Dec 7, 2023
Merged
[dotnet] Change a list of downloadable files to IReadOnlyList#13265titusfortner merged 2 commits intoSeleniumHQ:trunkfrom
titusfortner merged 2 commits intoSeleniumHQ:trunkfrom
Conversation
Member
|
Is this change worth breaking backwards compatibility without warning? |
Member
Author
|
There are 2 types of breaking changes: compilation compatibility and binary compatibility. This change is related to binary compatibility (even not sure), and is not related to compilation compatibility. I suppose only 0.01% of users might be impacted. |
titusfortner
approved these changes
Dec 7, 2023
Member
Author
|
I lied, it is compilation level breaking change. It breaks users who wrote: |
Member
|
I see how it is. Still want to do it, or put it back? |
Member
Author
|
Now or later... Given that selenium doesn't follow semver...
…On Fri, Dec 8, 2023, 12:09 AM Titus Fortner ***@***.***> wrote:
I see how it is. Still want to do it, or put it back?
—
Reply to this email directly, view it on GitHub
<#13265 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFMRXHUCFMN2BT7JGXZLDRLYIIWB7AVCNFSM6AAAAABALRIZ2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBWGEYTMNJYGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Retrieved list should be immutable.
Motivation and Context
Fixes #13264
Types of changes
Checklist