• Create ticket/issue

Follow the guide to enable codebase context checks.

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
Null options risk: The new OnFileDialogOpenedAsync overloads call options.WithContext(context) without an
explicit null-guard, which may throw if options is null depending on WithContext
implementation.

public Task<Subscription> OnFileDialogOpenedAsync(Func<FileDialogInfo, Task> handler, ContextSubscriptionOptions? options = null)
{
    return inputModule.OnFileDialogOpenedAsync(async e =>
    {
        if (context.Equals(e.Context))
        {
            await handler(e).ConfigureAwait(false);
        }
    }, options.WithContext(context));
}

public Task<Subscription> OnFileDialogOpenedAsync(Action<FileDialogInfo> handler, ContextSubscriptionOptions? options = null)
{
    return inputModule.OnFileDialogOpenedAsync((e) =>
    {
        if (context.Equals(e.Context))
        {
            handler(e);
        }
    }, options.WithContext(context));
}

Learn more about managing compliance generic rules or creating your own custom rules

Fix a potential NullReferenceException by handling the case where the options
parameter is null. Initialize a new ContextSubscriptionOptions if options is not
provided before calling WithContext.

dotnet/src/webdriver/BiDi/BrowsingContext/BrowsingContextInputModule.cs [44-64]

 public Task<Subscription> OnFileDialogOpenedAsync(Func<FileDialogInfo, Task> handler, ContextSubscriptionOptions? options = null)
 {
     return inputModule.OnFileDialogOpenedAsync(async e =>
     {
         if (context.Equals(e.Context))
         {
             await handler(e).ConfigureAwait(false);
         }
-    }, options.WithContext(context));
+    }, (options ?? new()).WithContext(context));
 }
 
 public Task<Subscription> OnFileDialogOpenedAsync(Action<FileDialogInfo> handler, ContextSubscriptionOptions? options = null)
 {
     return inputModule.OnFileDialogOpenedAsync((e) =>
     {
         if (context.Equals(e.Context))
         {
             handler(e);
         }
-    }, options.WithContext(context));
+    }, (options ?? new()).WithContext(context));
 }

• Apply / Chat

To improve API consistency, the Element property in the new FileDialogInfo
record should be changed from the concrete SharedReference class to the
ISharedReference interface. This aligns with existing methods like
SetFilesAsync.

Examples:

public sealed record FileDialogInfo(BrowsingContext.BrowsingContext Context, bool Multiple, Script.SharedReference? Element)
    : EventArgs;

    public async Task<SetFilesResult> SetFilesAsync(BrowsingContext.BrowsingContext context, Script.ISharedReference element, IEnumerable<string> files, SetFilesOptions? options = null)

Solution Walkthrough:

Before:

// file: dotnet/src/webdriver/BiDi/Input/FileDialogInfo.cs

public sealed record FileDialogInfo(
    BrowsingContext.BrowsingContext Context, 
    bool Multiple, 
    Script.SharedReference? Element // Exposes concrete class
) : EventArgs;

After:

// file: dotnet/src/webdriver/BiDi/Input/FileDialogInfo.cs

public sealed record FileDialogInfo(
    BrowsingContext.BrowsingContext Context, 
    bool Multiple, 
    Script.ISharedReference? Element // Exposes interface for better design
) : EventArgs;

Validate handler is non-null before passing it into the broker to fail fast with
a clear exception.

dotnet/src/webdriver/BiDi/Input/InputModule.cs [54-62]

-public async Task<Subscription> OnFileDialogOpenedAsync(Func<FileDialogInfo, Task> handler, SubscriptionOptions? options = null)
+public Task<Subscription> OnFileDialogOpenedAsync(Func<FileDialogInfo, Task> handler, SubscriptionOptions? options = null)
 {
-    return await Broker.SubscribeAsync("input.fileDialogOpened", handler, options, _jsonContext.FileDialogInfo).ConfigureAwait(false);
+    ArgumentNullException.ThrowIfNull(handler);
+    return Broker.SubscribeAsync("input.fileDialogOpened", handler, options, _jsonContext.FileDialogInfo);
 }
 
-public async Task<Subscription> OnFileDialogOpenedAsync(Action<FileDialogInfo> handler, SubscriptionOptions? options = null)
+public Task<Subscription> OnFileDialogOpenedAsync(Action<FileDialogInfo> handler, SubscriptionOptions? options = null)
 {
-    return await Broker.SubscribeAsync("input.fileDialogOpened", handler, options, _jsonContext.FileDialogInfo).ConfigureAwait(false);
+    ArgumentNullException.ThrowIfNull(handler);
+    return Broker.SubscribeAsync("input.fileDialogOpened", handler, options, _jsonContext.FileDialogInfo);
 }

• Apply / Chat