Skip to content

[java] If a dep comes from a BOM, omit the version number#15682

Merged
shs96c merged 4 commits intoSeleniumHQ:trunkfrom
shs96c:minor-bumps
May 1, 2025
Merged

[java] If a dep comes from a BOM, omit the version number#15682
shs96c merged 4 commits intoSeleniumHQ:trunkfrom
shs96c:minor-bumps

Conversation

@shs96c
Copy link
Copy Markdown
Member

@shs96c shs96c commented Apr 30, 2025 •
edited by qodo-code-review bot
Loading

PR Type

Enhancement

Description

  • Omit version numbers for BOM-managed dependencies in MODULE.bazel

  • Downgrade Netty and OpenTelemetry dependencies to earlier versions

  • Downgrade JUnit Jupiter and Platform dependencies to earlier versions

  • Remove unused OpenTest4J reporting dependency from Maven install

Changes walkthrough 📝

Relevant files
Enhancement
MODULE.bazel
Omit BOM-managed dependency versions in Bazel module         

MODULE.bazel

  • Removed explicit versions for dependencies managed by BOM
  • Updated dependency list to omit versions for Netty, OpenTelemetry, and
    JUnit
    		• +23/-23 
    maven_install.json
    Update dependency versions and remove unused artifact       

    java/maven_install.json

  • Updated artifact versions for Netty, OpenTelemetry, and JUnit to
    earlier releases
  • Removed OpenTest4J reporting-tooling-spi dependency and related
    references
  • Adjusted dependency trees and package lists to match new versions
    		• +75/-92 
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @selenium-ci selenium-ci added C-java Java Bindings B-build Includes scripting, bazel and CI integrations labels Apr 30, 2025
    @qodo-code-review
    Copy link
    Copy Markdown
    Contributor

    qodo-code-review bot commented Apr 30, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Dependency Management

    The PR removes explicit version numbers for dependencies managed by BOMs, which is good practice. However, verify that the project correctly defines these BOMs elsewhere to ensure version resolution works properly.

     
    "io.netty:netty-buffer",
"io.netty:netty-codec-http",
"io.netty:netty-codec-http2",
"io.netty:netty-common",
"io.netty:netty-handler",
"io.netty:netty-handler-proxy",
"io.netty:netty-transport",
"io.opentelemetry:opentelemetry-api",
"io.opentelemetry:opentelemetry-context",
"io.opentelemetry:opentelemetry-exporter-logging",
"io.opentelemetry:opentelemetry-sdk",
"io.opentelemetry:opentelemetry-sdk-common",
"io.opentelemetry:opentelemetry-sdk-extension-autoconfigure",
"io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi",
"io.opentelemetry:opentelemetry-sdk-testing",
"io.opentelemetry:opentelemetry-sdk-trace",
    Version Downgrade

    Multiple dependencies (Netty, OpenTelemetry, JUnit) are being downgraded to earlier versions. Ensure these downgrades don't introduce compatibility issues with other components in the system.

     
        "jar": "0eea4e8666a9636a28722661d8ba5fa8564477e75fec6dd2ff3e324e361f8b3c",
    "sources": "554d9b4e1211c0fe7e6703d8449755b226b48eea680c95fbcc246207c9f4835e"
  },
  "version": "4.1.118.Final"
},
"io.netty:netty-codec": {
  "shasums": {
    "jar": "4abd215fd1ed7ce86509d169cc9cbede5042176c265a79b3b70602b017226c3f",
    "sources": "b1bdf9c511810a1f0a5485e1d652e0883f35118224d4dc21ef7edd4c822a477d"
  },
  "version": "4.1.118.Final"
},
"io.netty:netty-codec-dns": {
  "shasums": {
    "jar": "e115e42ca1e3cc8d85e3a632d8faa102d18c0ebc1fa4511af30bec79f8c147d4",
    "sources": "ede3ae4ee1e0476c00da1e04927cc2bdc3ca84f9b506378a3b82e333b7053d6a"
  },
  "version": "4.1.118.Final"
},
"io.netty:netty-codec-http": {
  "shasums": {
    "jar": "09822d785e9a794838031ddd5346cf419b30c036a981c2e277a062bea884174b",
    "sources": "637f46d46c300cdcb097aab6ed89013fca85bb89b798763fc962e09a3b91cef2"
  },
  "version": "4.1.118.Final"
},
"io.netty:netty-codec-http2": {
  "shasums": {
    "jar": "68da0b1a34dceb00a6f9f6f788fb2f6b7b9e4adba8c70658ac2bd7eb898b97ae",
    "sources": "3850183e9d162944439b78dccbc9907cf06d66abc8116f56ebc03cb3256042a7"
  },
  "version": "4.1.118.Final"

    @qodo-code-review
    Copy link
    Copy Markdown
    Contributor

    qodo-code-review bot commented Apr 30, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @shs96c shs96c merged commit adf0c4c into SeleniumHQ:trunk May 1, 2025
    11 checks passed
    @shs96c shs96c deleted the minor-bumps branch May 1, 2025 09:27
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    B-build Includes scripting, bazel and CI integrations C-java Java Bindings Review effort 2/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @shs96c @selenium-ci