Conversation
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
It looks like an update for test fixture or something which enable downloads from the beginning, so the expectation in test not happen anymore.
Adding a step to reset the driver state with
enable_downloads: falseto get expect exception in testMotivation and Context
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
driver_spec.rbby adding a step to reset the driver state withenable_downloads: false.WebDriverErrorwhen downloads are not enabled.PRDescriptionHeader.CHANGES_WALKTHROUGH
driver_spec.rb
Fix test by resetting driver state for download settingsrb/spec/integration/selenium/webdriver/remote/driver_spec.rb
enable_downloads: false.reset.
enabled.