Skip to content

[dotnet][rb][java][js][py] Automated Browser Version Update#13841

Merged
diemol merged 2 commits intotrunkfrom
pinned-browser-updates
Apr 25, 2024
Merged

[dotnet][rb][java][js][py] Automated Browser Version Update#13841
diemol merged 2 commits intotrunkfrom
pinned-browser-updates

Conversation

@selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Apr 19, 2024 •
edited
Loading

This is an automated pull request to update pinned browsers and drivers

Merge after verify the new browser versions properly passing the tests and no bugs need to be filed

@qodo-code-review qodo-code-review bot added the P-enhancement PR with a new feature label Apr 19, 2024
@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Apr 19, 2024

PR Description updated to latest commit (04bbf84)

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Apr 19, 2024

PR Review

⏱️ Estimated effort to review [1-5]

2, because the changes are straightforward and limited to updating URLs and SHA256 hashes for browser packages. The scope is narrow and the changes are repetitive, making it easier to review.

🧪 Relevant tests

No

🔍 Possible issues

Incorrect Hashes: Ensure that the SHA256 hashes match the actual files downloaded from the new URLs to prevent any integrity issues.

🔒 Security concerns

No
✨ Review tool usage guide:

Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

  • When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Apr 19, 2024

PR Code Suggestions

CategorySuggestions                                                                                                                                                       
Possible issue
Update the file path in the move dictionary to match the new package structure.

Ensure that the move dictionary in pkg_archive for "mac_edge" is updated to reflect the
new package version. The old version key is still being used, which might not work with
the new package structure.

common/repositories.bzl [129]

 move = {
-    "MicrosoftEdge-124.0.2478.51.pkg/Payload/Microsoft Edge.app": "Edge.app",
+    "MicrosoftEdge-124.0.2478.51.pkg/Payload/MicrosoftEdge.app": "Edge.app",
 }
✨ Improve tool usage guide:

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

  • When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:
/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

[pr_code_suggestions]
some_config1=...
some_config2=...

See the improve usage page for a comprehensive guide on using this tool.

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Apr 19, 2024 •
edited
Loading

CI Failure Feedback

(Checks updated until commit 6152634)

Action: Ruby / Local Tests (firefox, windows) / Local Tests (firefox, windows)

Failed stage: Run Bazel [❌]

Failure summary:

The action failed due to a timeout error while fetching the repository rules_rubyruby~ruby. This
occurred during the execution of the rb_download rule defined in download.bzl. The timeout prevented
the repository from being fetched, which in turn caused the failure of the target
//rb/spec/integration/selenium/webdriver:error-firefox as it depends on the toolchain from the
rules_rubyruby~ruby repository.

Relevant error logs: 
1:  ##[group]Operating System
2:  Microsoft Windows Server 2022
...

567:  �[32mAnalyzing:�[0m 26 targets (331 packages loaded, 7209 targets configured)
568:  �[32m[1 / 1]�[0m checking cached actions
569:  �[32mAnalyzing:�[0m 26 targets (337 packages loaded, 8479 targets configured)
570:  �[32m[1 / 1]�[0m checking cached actions
571:  �[32mINFO: �[0mRepository rules_ruby~~ruby~ruby instantiated at:
572:  <builtin>: in <toplevel>
573:  Repository rule rb_download defined at:
574:  D:/_bazel/external/rules_ruby~/ruby/private/download.bzl:190:30: in <toplevel>
575:  �[31m�[1mERROR: �[0mAn error occurred during the fetch of repository 'rules_ruby~~ruby~ruby':
576:  Traceback (most recent call last):
577:  File "D:/_bazel/external/rules_ruby~/ruby/private/download.bzl", line 51, column 35, in _rb_download_impl
578:  _install_via_rubyinstaller(repository_ctx, version)
579:  File "D:/_bazel/external/rules_ruby~/ruby/private/download.bzl", line 134, column 13, in _install_via_rubyinstaller
580:  fail("%s\n%s" % (result.stdout, result.stderr))
581:  Error in fail: 
582:  Timed out
583:  �[31m�[1mERROR: �[0m<builtin>: fetching rb_download rule //:rules_ruby~~ruby~ruby: Traceback (most recent call last):
584:  File "D:/_bazel/external/rules_ruby~/ruby/private/download.bzl", line 51, column 35, in _rb_download_impl
585:  _install_via_rubyinstaller(repository_ctx, version)
586:  File "D:/_bazel/external/rules_ruby~/ruby/private/download.bzl", line 134, column 13, in _install_via_rubyinstaller
587:  fail("%s\n%s" % (result.stdout, result.stderr))
588:  Error in fail: 
589:  Timed out
590:  �[31m�[1mERROR: �[0mno such package '@@rules_ruby~~ruby~ruby//': 
591:  Timed out
592:  �[31m�[1mERROR: �[0mD:/a/selenium/selenium/rb/spec/integration/selenium/webdriver/BUILD.bazel:31:24: //rb/spec/integration/selenium/webdriver:error-firefox depends on @@rules_ruby~~ruby~ruby//:toolchain in repository @@rules_ruby~~ruby~ruby which failed to fetch. no such package '@@rules_ruby~~ruby~ruby//': 
593:  Timed out
594:  �[32mAnalyzing:�[0m 26 targets (337 packages loaded, 8479 targets configured)
595:  �[32m[1 / 1]�[0m checking cached actions
596:  �[31m�[1mERROR: �[0mAnalysis of target '//rb/spec/integration/selenium/webdriver:error-firefox' failed; build aborted: Analysis failed
597:  �[32mINFO: �[0mElapsed time: 658.190s, Critical Path: 1.41s
598:  �[32mINFO: �[0m1 process: 1 internal.
599:  �[31m�[1mERROR: �[0mBuild did NOT complete successfully
600:  �[31m�[1mERROR: �[0mNo test targets were found, yet testing was requested
601:  �[0m
602:  ##[error]Process completed with exit code 1.
✨ CI feedback usage guide:

The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:

  • Failed stage
  • Failed test name
  • Failure summary
  • Relevant error logs

In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

Configuration options

  • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
  • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
  • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
  • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
  • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

See more information about the checks tool in the docs.

@selenium-ci selenium-ci force-pushed the pinned-browser-updates branch 3 times, most recently from 7a109ba to 19cfc3c Compare April 24, 2024 00:32
@selenium-ci selenium-ci force-pushed the pinned-browser-updates branch from 19cfc3c to ff71f90 Compare April 25, 2024 00:32
@diemol diemol merged commit 8723d04 into trunk Apr 25, 2024
@diemol diemol deleted the pinned-browser-updates branch April 25, 2024 15:54
@MiguelPelegrina MiguelPelegrina mentioned this pull request Jun 6, 2024
Merged
@x-way x-way mentioned this pull request Jun 10, 2024
Closed
@farmmanic farmmanic mentioned this pull request Jun 14, 2024
Open
@LunarArtemis LunarArtemis mentioned this pull request Jun 22, 2024
Open
@MiguelPelegrina MiguelPelegrina mentioned this pull request Jul 12, 2024
Merged
@aravindb26 aravindb26 mentioned this pull request Jul 16, 2024
Open
@x-way x-way mentioned this pull request Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

P-enhancement PR with a new feature Review effort [1-5]: 2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@selenium-ci @diemol