[dotnet] Correct ChromiumDriverService.AllowedIPAddresses property name#13626
Merged
diemol merged 1 commit intoSeleniumHQ:trunkfrom Feb 26, 2024
Merged
Conversation
7e1ac2b to
d1af3dd
Compare
diemol
approved these changes
Feb 26, 2024
Member
diemol
left a comment
There was a problem hiding this comment.
Thank you, @YevgeniyShunevych!
Contributor
Author
|
No problem, @diemol. I think maybe you can even consider releasing this as v4.18.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a correction of commit e7fb98b made in v4.18. If you check that commit changes, you should see that the old property
WhitelistedIPAddressesactually was renamed, I believe accidentally, toWhitelistedIpAddressesmarked with[Obsolete]attribute.IP->Ip. So it turned to a breaking change that was not intended to be. So I renamed that old property back. Additionally, actual newAllowedIpAddressesproperty doesn't follow C# naming convention withIp. So I corrected it to haveIPas well.Motivation and Context
Types of changes
Checklist