[Bugfix] Refactored code in the WebDriverException class:#12933
Merged
pujagani merged 3 commits intoSeleniumHQ:trunkfrom Oct 12, 2023
Merged
[Bugfix] Refactored code in the WebDriverException class:#12933pujagani merged 3 commits intoSeleniumHQ:trunkfrom
pujagani merged 3 commits intoSeleniumHQ:trunkfrom
Conversation
- Replaced the filter expression from checking if a string is not null or empty using s == null || s.equals("") to s == null || s.isEmpty().
Updated a comment in the public enum WindowType:
- Changed the comment from "Represents the type of a new browser window that may be created." to "Represents the type of new browser window that may be created."
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #12933 +/- ##
=======================================
Coverage 56.51% 56.51%
=======================================
Files 86 86
Lines 5255 5255
Branches 187 187
=======================================
Hits 2970 2970
Misses 2098 2098
Partials 187 187 ☔ View full report in Codecov by Sentry. |
pujagani
approved these changes
Oct 12, 2023
Contributor
pujagani
left a comment
There was a problem hiding this comment.
Thank you @manuelsblanco!
aguspe
pushed a commit
to aguspe/selenium
that referenced
this pull request
Oct 22, 2023
…#12933) Co-authored-by: Puja Jagani <puja.jagani93@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated a comment in the public enum WindowType:
Description
Corrected a typo and used the IsEmpty() method instead of comparing with an empty string
Motivation and Context
Improve code quality by using the appropriate type of comparison
Types of changes
Checklist