[rust] Fix config setup in Selenium Manager#12807
Merged
titusfortner merged 5 commits intotrunkfrom Sep 24, 2023
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #12807 +/- ##
=======================================
Coverage 56.53% 56.53%
=======================================
Files 86 86
Lines 5253 5253
Branches 187 187
=======================================
Hits 2970 2970
Misses 2096 2096
Partials 187 187 ☔ View full report in Codecov by Sentry. |
Member
|
Looks good, but I'm not merging any code until we get the CI happy again. |
ab95227 to
81962e2
Compare
Member
|
@vivin-joghee can you paste the reproducible code, error/stack trace and Log output in that issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the logic for reading the configuration file and envs in Selenium Manager.
Motivation and Context
This PR should fix #12789 and #12782.
Types of changes
Checklist