[dotnet] Remove Microsoft.IdentityModel.Tokens as dependency#12777
Merged
titusfortner merged 9 commits intoSeleniumHQ:trunkfrom Sep 25, 2023
Merged
[dotnet] Remove Microsoft.IdentityModel.Tokens as dependency#12777titusfortner merged 9 commits intoSeleniumHQ:trunkfrom
titusfortner merged 9 commits intoSeleniumHQ:trunkfrom
Conversation
8 tasks
titusfortner
requested changes
Sep 24, 2023
Member
titusfortner
left a comment
There was a problem hiding this comment.
This looks good to me, will be nice to remove the dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We can remove
Microsoft.IdentityModel.Tokensdependency.What is done:
Microsoft.IdentityModel.TokensOriginal source: https://raw.githubusercontent.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/6.19.0/src/Microsoft.IdentityModel.Tokens/Base64UrlEncoder.cs
Motivation and Context
Ideally any library should not have dependencies.
Related to #12692
Types of changes
Checklist