Look for Selenium Manager in path defined by Environment Variable#12752
Look for Selenium Manager in path defined by Environment Variable#12752titusfortner merged 5 commits intotrunkfrom
Conversation
|
I guess I should say, this doesn't *have to be an alternative. We could do both. I think if we want to get 4.13 out soon, this one is sufficient for that need instead of waiting to implement #11359 in all the languages. |
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #12752 +/- ##
==========================================
- Coverage 56.53% 56.51% -0.03%
==========================================
Files 86 86
Lines 5253 5255 +2
Branches 187 187
==========================================
Hits 2970 2970
- Misses 2096 2098 +2
Partials 187 187
☔ View full report in Codecov by Sentry. |
|
Hmm, but looks like I broke some tests. 😂 |
|
Hah, busted for not using Java 8 syntax. Hopefully last time that ever happens. |
b57fb80 to
1a951fb
Compare
|
Ok, so I made a few important changes.
|
773f73a to
bc8ff6a
Compare
bc8ff6a to
273888c
Compare
nvborisenko
left a comment
There was a problem hiding this comment.
.net code reads env variable twice, can be improved.
273888c to
ac55971
Compare
…ronment variable This allows people to build or download the binary as necessary and place it in any directory It may also be helpful for package managers or people who have permissions issues in directories
…vironment variable
ac55971 to
68c5eb2
Compare
Description
SE_MANAGER_PATHenvironment variable for Selenium Manager first before looking in the standard locationMotivation and Context