[java] Use new 'getArray' method to extract driver configurations#12716
Merged
diemol merged 2 commits intoSeleniumHQ:trunkfrom Oct 7, 2023
Merged
[java] Use new 'getArray' method to extract driver configurations#12716diemol merged 2 commits intoSeleniumHQ:trunkfrom
diemol merged 2 commits intoSeleniumHQ:trunkfrom
Conversation
7457789 to
5976220
Compare
09cd7d0 to
10df5be
Compare
efb2423 to
66347a8
Compare
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #12716 +/- ##
=======================================
Coverage 56.51% 56.51%
=======================================
Files 86 86
Lines 5255 5255
Branches 187 187
=======================================
Hits 2970 2970
Misses 2098 2098
Partials 187 187 ☔ View full report in Codecov by Sentry. |
9f72953 to
bc68a0d
Compare
c388f7f to
2e1338b
Compare
Contributor
|
@sbabcoc - If this implementation is ready to be reviewed, maybe you can help add a test to this as well and drop a message. If it's still WIP maybe you could have this PR in draft ? |
Contributor
Author
|
@krmahadevan This is ready for review. The existing unit tests cover these revisions. |
ed9783c to
ca81b92
Compare
e721134 to
5155821
Compare
5155821 to
54caf4c
Compare
diemol
approved these changes
Oct 5, 2023
aguspe
pushed a commit
to aguspe/selenium
that referenced
this pull request
Oct 22, 2023
…leniumHQ#12716) Use new 'getArray' method; fix formatting Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I eliminate the need to deal with
Config.DELIMITERby using the newgetArraymethod.Motivation and Context
This specific implementation was the original motivation for a series of PRs to introduce an unambiguous delimiter into flat lists of associated settings. My previous PR added the
Config.getArraymethod, which returns delimited lists of associated settings as a list of lists, eliminating the need for client code to perform this operation.Types of changes
Checklist