[rb] Fix wrongly trying to load a constant#11931
Merged
titusfortner merged 1 commit intoSeleniumHQ:trunkfrom Apr 23, 2023
boris-petrov:fix-typo
Merged
[rb] Fix wrongly trying to load a constant#11931titusfortner merged 1 commit intoSeleniumHQ:trunkfrom boris-petrov:fix-typo
titusfortner merged 1 commit intoSeleniumHQ:trunkfrom
boris-petrov:fix-typo
Conversation
Member
|
thanks! |
oriongonza
pushed a commit
to oriongonza/selenium
that referenced
this pull request
Apr 24, 2023
|
It took me a while googling this exact error: NameError:
wrong constant name Target}But I finally got here 😄 Thank you for fixing this! |
|
I am trying to intercept requests and hit this problem. And no, even with this fix, interception still won't work. |
Member
|
Replying to a closed issue with a different problem is not helpful. It it's a bug, please open a new issue with all of the requested details. |
Member
|
@boris-petrov Such a silly mistake from me, thanks for fixing! |
|
Is a release of the gem with the fix planned? |
Member
|
@ylecuyer Chrome 113 should be released today. After that, we'll ship a new selenium-devtools release. |
Apologies @titusfortner, you are right! I've created an issue: #12040 for my problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was one
}too many.Motivation and Context
Otherwise people get:
Types of changes
Checklist