[java] [cdp] Simplify Augmentation for Basic Auth#11601
Merged
pujagani merged 5 commits intoSeleniumHQ:trunkfrom Feb 2, 2023
Merged
[java] [cdp] Simplify Augmentation for Basic Auth#11601pujagani merged 5 commits intoSeleniumHQ:trunkfrom
pujagani merged 5 commits intoSeleniumHQ:trunkfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #11601 +/- ##
=======================================
Coverage 54.65% 54.65%
=======================================
Files 85 85
Lines 5643 5643
Branches 244 244
=======================================
Hits 3084 3084
Misses 2315 2315
Partials 244 244 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
diemol
reviewed
Feb 2, 2023
Member
diemol
left a comment
There was a problem hiding this comment.
Code changes look fine to me, thank you!
If CI looks good, feel free to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Simplify Augmentation for Basic Auth
Motivation and Context
Ensure the following code snippet works for the users, instead of providing BasicAuth implementation themselves :
Types of changes
Checklist