Skip to content

[java][cdp] Keep track of pinned scripts per CDP session#11598

Merged
pujagani merged 2 commits intoSeleniumHQ:trunkfrom
pujagani:fix-javascript-pinning
Jan 31, 2023
Merged

[java][cdp] Keep track of pinned scripts per CDP session#11598
pujagani merged 2 commits intoSeleniumHQ:trunkfrom
pujagani:fix-javascript-pinning

Conversation

@pujagani
Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fixes #11573.

Motivation and Context

Allow script pinning with CDP for a different window/tab.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani pujagani merged commit 20d68b3 into SeleniumHQ:trunk Jan 31, 2023
mialeska added a commit to aquality-automation/aquality-selenium-java that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: DevTools Javascript Pin Does not work on new Tab or Window in same browser session.

2 participants