Skip to content

pylint fixes including tidy of f strings, simplifications of conditional statements and isinstances#11205

Merged
diemol merged 12 commits intoSeleniumHQ:trunkfrom
marksmayo:trunk
Jan 24, 2023
Merged

pylint fixes including tidy of f strings, simplifications of conditional statements and isinstances#11205
diemol merged 12 commits intoSeleniumHQ:trunkfrom
marksmayo:trunk

Conversation

@marksmayo
Copy link
Copy Markdown
Contributor

Tidying up of a bunch of pylint issues

Description

pylint fixes including tidy of f strings, simplifications of conditional statements and isinstances

Motivation and Context

linting issues can hide major defects

Types of changes

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [X ] I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • [X ] All new and existing tests passed.

Tidying up of a bunch of pylint issues
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 1, 2022

CLA assistant check
All committers have signed the CLA.

@titusfortner titusfortner requested a review from symonk November 2, 2022 19:40
@titusfortner titusfortner added the C-py Python Bindings label Nov 3, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 10, 2022

Codecov Report

Base: 54.66% // Head: 54.65% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (537f053) compared to base (484359c).
Patch coverage: 28.57% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #11205      +/-   ##
==========================================
- Coverage   54.66%   54.65%   -0.02%     
==========================================
  Files          85       85              
  Lines        5643     5643              
  Branches      243      244       +1     
==========================================
- Hits         3085     3084       -1     
  Misses       2315     2315              
- Partials      243      244       +1     
Impacted Files Coverage Δ
py/selenium/webdriver/chromium/webdriver.py 54.94% <0.00%> (ø)
py/selenium/webdriver/common/bidi/cdp.py 22.96% <0.00%> (ø)
py/selenium/webdriver/remote/webdriver.py 41.45% <0.00%> (-0.20%) ⬇️
py/selenium/webdriver/common/service.py 95.72% <100.00%> (ø)
py/selenium/webdriver/remote/webelement.py 36.51% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @marksmayo!

@diemol diemol merged commit 3f6717d into SeleniumHQ:trunk Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-py Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants