Conversation
Member
|
FWIW I went through the repos and set the permissions to read-only quite awhile ago: https://github.com/RustCrypto/utils/settings/actions
This could be belt-and-suspenders, I guess, but using administrative actions rather than configurations seems like a bit more surefire approach. |
Member
Author
|
It looks like this setting is equivalent to the restricted column with some additional rights to manipulate pull requests. It will be hard to do something malicious with such rights, but either way using tighter permissions probably will not hurt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For most jobs we only need to read the contents to run tests. But I am not sure which permissions should be used for the security audit job. I think it should be something like:
For now I will leave the default permissions.
Relevant issues: actions-rs/audit-check#218, actions-rs/audit-check#220