feat: add targets support for scorecardClassic#2651
Merged
AlbinaBlazhko17 merged 25 commits intomainfrom Mar 18, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: a4b3851 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
targets support for scorecardClassic
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
|
JLekawa
reviewed
Mar 13, 2026
Contributor
|
It might be a good idea to add some documentation for this property. |
Contributor
Author
|
@JLekawa the whole config for |
JLekawa
approved these changes
Mar 13, 2026
tatomyr
reviewed
Mar 13, 2026
tatomyr
reviewed
Mar 13, 2026
tatomyr
reviewed
Mar 16, 2026
tatomyr
reviewed
Mar 17, 2026
tatomyr
reviewed
Mar 17, 2026
tatomyr
reviewed
Mar 17, 2026
| } | ||
|
|
||
| for (const target of targets) { | ||
| const matches = Object.entries(target.where?.metadata || {}).every(([key, value]) => { |
Collaborator
There was a problem hiding this comment.
Please extract the callback to a named function so the name conveys the intention.
tatomyr
approved these changes
Mar 17, 2026
| levels: [{ name: 'Baseline' }], | ||
| targets: [{ where: { metadata: { env: 'prod' } }, minimumLevel: 'Gold' }], | ||
| }; | ||
| expect(getTarget(scorecardConfig.targets, { env: 'dev' })?.minimumLevel).toBeUndefined(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| expect(getTarget(scorecardConfig.targets, { env: 'dev' })?.minimumLevel).toBeUndefined(); | |
| expect(getTarget(scorecardConfig.targets, { env: 'dev' })!.minimumLevel).toBeUndefined(); |
Contributor
Author
There was a problem hiding this comment.
This will throw an error, because the purpose of this test is to check if it is undefined
Collaborator
There was a problem hiding this comment.
Oh, indeed. Didn't notice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
targetsproperty inscorecardClassiccommand. Usingtargetsproperty we can override rules insidescorecardClassicfor specific api, which matches the criteria's under where statement. We find the matching api usingmetadata. We can add metadata in three places: under api in config, inside openapi file inx-metadataortitleandversioninside openapi. If the target matches we apply rules for the levels.Reference
Resolves #2580
Testing
Locally.
Screenshots (optional)
Check yourself
Security