Skip to content

feat: add support for NO_PROXY environment variable#2643

Merged
DmitryAnansky merged 3 commits intomainfrom
feat/add-support-for-no-proxy-env-var
Mar 11, 2026
Merged

feat: add support for NO_PROXY environment variable#2643
DmitryAnansky merged 3 commits intomainfrom
feat/add-support-for-no-proxy-env-var

Conversation

@DmitryAnansky
Copy link
Copy Markdown
Contributor

@DmitryAnansky DmitryAnansky commented Mar 10, 2026 •
edited
Loading

What/Why/How?

Added support for NO_PROXY environment variable.
Users will be able to add domains you do not want to be forwarded through proxy.

Reference

Closes: #2641

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with Redoc/Realm/Reunite (internal)
  • All new/updated code is covered by tests
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

@DmitryAnansky DmitryAnansky requested review from a team as code owners March 10, 2026 23:45
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 10, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 41e1b82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@redocly/cli Minor
@redocly/openapi-core Minor
@redocly/respect-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DmitryAnansky DmitryAnansky marked this pull request as draft March 10, 2026 23:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 10, 2026 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.18% (🎯 79%) 6396 / 8077
🔵 Statements 78.64% (🎯 78%) 6613 / 8409
🔵 Functions 82.44% (🎯 82%) 1310 / 1589
🔵 Branches 71.11% (🎯 70%) 4367 / 6141
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/cli/src/commands/respect/connection-client.ts 55.17% 56.09% 50% 55.17% 65-101
packages/cli/src/utils/fetch-with-timeout.ts 100% 100% 100% 100%
packages/cli/src/utils/proxy-agent.ts 82.6% 87.5% 80% 82.35% 13-14, 25, 31
Generated in workflow #8936 for commit 41e1b82 by the Vitest Coverage Report Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 10, 2026 •
edited
Loading

CLI Version Mean Time ± Std Dev (s) Relative Performance (Lower is Faster)
cli-latest 3.438s ± 0.051s ▓ 1.00x
cli-next 3.423s ± 0.018s ▓ 1.00x (Fastest)

@DmitryAnansky DmitryAnansky self-assigned this Mar 11, 2026
@DmitryAnansky DmitryAnansky added the Respect Related to the `respect` command which works with Arazzo specification label Mar 11, 2026
@DmitryAnansky DmitryAnansky force-pushed the feat/add-support-for-no-proxy-env-var branch from dbf295c to 5605c0b Compare March 11, 2026 10:09
@DmitryAnansky DmitryAnansky marked this pull request as ready for review March 11, 2026 10:10
@DmitryAnansky DmitryAnansky force-pushed the feat/add-support-for-no-proxy-env-var branch from 5605c0b to 90e79e9 Compare March 11, 2026 11:47
kanoru3101
kanoru3101 approved these changes Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kanoru3101 kanoru3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only thing I don't like is the division of envs into upper and lower case letters. It would be good to come up with a helper that would handle this.

Comment thread .changeset/solid-jeans-report.md Outdated
Comment thread packages/cli/src/utils/proxy-agent.ts
@DmitryAnansky DmitryAnansky merged commit c6c9587 into main Mar 11, 2026
61 of 62 checks passed
@DmitryAnansky DmitryAnansky deleted the feat/add-support-for-no-proxy-env-var branch March 11, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tatomyr tatomyr tatomyr approved these changes

@kanoru3101 kanoru3101 kanoru3101 approved these changes

@JLekawa JLekawa JLekawa approved these changes

Assignees

@DmitryAnansky DmitryAnansky

Labels

Respect Related to the `respect` command which works with Arazzo specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

$NO_PROXY environment variable is ignored when using respect

4 participants

@DmitryAnansky @tatomyr @kanoru3101 @JLekawa