fix: reported error location at correct node for parameters#2626
Merged
kanoru3101 merged 13 commits intomainfrom Mar 4, 2026
Merged
fix: reported error location at correct node for parameters#2626kanoru3101 merged 13 commits intomainfrom
kanoru3101 merged 13 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 289c664 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
📦 A new experimental 🧪 version v0.0.0-snapshot.1772460631 of Redocly CLI has been published for testing. Install with NPM: npm install @redocly/cli@0.0.0-snapshot.1772460631
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1772460631
# or
npm install @redocly/respect-core@0.0.0-snapshot.1772460631 |
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Contributor
|
tatomyr
reviewed
Mar 2, 2026
tatomyr
reviewed
Mar 2, 2026
packages/core/src/rules/common/__tests__/path-params-defined.test.ts
Outdated
Show resolved
Hide resolved
tatomyr
reviewed
Mar 2, 2026
tatomyr
reviewed
Mar 2, 2026
tatomyr
reviewed
Mar 2, 2026
Collaborator
tatomyr
left a comment
There was a problem hiding this comment.
Please also add an e2e test with transitive $refs.
Co-authored-by: Andrew Tatomyr <andrew.tatomyr@redocly.com>
JLekawa
approved these changes
Mar 3, 2026
tatomyr
reviewed
Mar 4, 2026
tatomyr
reviewed
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
For parameters referenced via
$ref, the error location now points at the$refusage instead of the component definition.Reference
#1241
Testing
Screenshots (optional)
Check yourself
Security