Skip to content

chore: restructure join command without changing logic#2611

Merged
DmitryAnansky merged 2 commits intomainfrom
chore/join-command-restructure
Feb 27, 2026
Merged

chore: restructure join command without changing logic#2611
DmitryAnansky merged 2 commits intomainfrom
chore/join-command-restructure

Conversation

@DmitryAnansky
Copy link
Contributor

@DmitryAnansky DmitryAnansky commented Feb 26, 2026 •
edited
Loading

What/Why/How?

Restructured join command without changing logic.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with Redoc/Realm/Reunite (internal)
  • All new/updated code is covered by tests
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: af1b4ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.17% (🎯 79%) 6379 / 8057
🔵 Statements 78.62% (🎯 78%) 6591 / 8383
🔵 Functions 82.53% (🎯 82%) 1309 / 1586
🔵 Branches 71% (🎯 70%) 4341 / 6114
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/cli/src/types.ts 100% 100% 100% 100%
packages/cli/src/commands/join/index.ts 90.27% 83.67% 85.71% 90.14% 106, 114-123, 145, 187, 201, 219
packages/cli/src/commands/join/helpers/add-components-prefix.ts 33.33% 100% 50% 33.33% 7-8
packages/cli/src/commands/join/helpers/add-info-section.ts 81.81% 66.66% 100% 100% 14, 15
packages/cli/src/commands/join/helpers/add-prefix.ts 100% 100% 100% 100%
packages/cli/src/commands/join/helpers/add-security-prefix.ts 0% 0% 0% 0% 2-8
packages/cli/src/commands/join/helpers/collect-components.ts 100% 87.5% 100% 100%
packages/cli/src/commands/join/helpers/collect-external-docs.ts 42.85% 25% 100% 42.85% 19-23
packages/cli/src/commands/join/helpers/collect-paths.ts 74.07% 55.55% 85.71% 73.75% 79-80, 87, 98-101, 113, 124-135, 154, 211-214, 216-229
packages/cli/src/commands/join/helpers/collect-webhooks.ts 22.22% 25% 50% 22.22% 31-65
packages/cli/src/commands/join/helpers/duplicate-tag-description-warning.ts 0% 100% 0% 0% 5-11
packages/cli/src/commands/join/helpers/filter-conflicts.ts 100% 100% 100% 100%
packages/cli/src/commands/join/helpers/format-tags.ts 100% 100% 100% 100%
packages/cli/src/commands/join/helpers/get-api-filename.ts 100% 100% 100% 100%
packages/cli/src/commands/join/helpers/get-info-prefix.ts 63.63% 60% 100% 66.66% 8, 10-12, 14, 16-20
packages/cli/src/commands/join/helpers/iterate-potential-conflicts.ts 21.42% 5.55% 25% 24% 11-22, 38-56
packages/cli/src/commands/join/helpers/populate-tags.ts 80.85% 55.93% 87.5% 81.81% 36, 41, 52-56, 60-61, 67, 106, 111
packages/cli/src/commands/join/helpers/prefix-tag-suggestion.ts 0% 100% 0% 0% 5-13
packages/cli/src/commands/join/helpers/replace-$-refs.ts 100% 93.75% 100% 100%
packages/cli/src/commands/join/helpers/show-conflicts.ts 0% 100% 0% 0% 5-6
Generated in workflow #8815 for commit af1b4ad by the Vitest Coverage Report Action

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026 •
edited
Loading

CLI Version Mean Time ± Std Dev (s) Relative Performance (Lower is Faster)
cli-latest 3.647s ± 0.099s ▓ 1.03x
cli-next 3.536s ± 0.025s ▓ 1.00x (Fastest)

@DmitryAnansky DmitryAnansky marked this pull request as ready for review February 26, 2026 22:32
@DmitryAnansky DmitryAnansky requested a review from a team as a code owner February 26, 2026 22:32
@DmitryAnansky DmitryAnansky force-pushed the chore/join-command-restructure branch from 0858ba0 to af1b4ad Compare February 27, 2026 08:17
@DmitryAnansky DmitryAnansky merged commit d27bfdb into main Feb 27, 2026
57 of 59 checks passed
@DmitryAnansky DmitryAnansky deleted the chore/join-command-restructure branch February 27, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tatomyr tatomyr tatomyr approved these changes

Assignees

No one assigned

Labels

no changeset needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DmitryAnansky @tatomyr