Skip to content

feat: add missing visitors and config types for scorecard classic#2589

Merged
AlbinaBlazhko17 merged 8 commits intomainfrom
fix/scorecard-classic-not-resolving-plugins
Feb 24, 2026
Merged

feat: add missing visitors and config types for scorecard classic#2589
AlbinaBlazhko17 merged 8 commits intomainfrom
fix/scorecard-classic-not-resolving-plugins

Conversation

@AlbinaBlazhko17
Copy link
Contributor

@AlbinaBlazhko17 AlbinaBlazhko17 commented Feb 20, 2026

What/Why/How?

  • Added missing visitors for scorecardClassic. The issue is based on loading not resolved config while using scorecardClassic in config.

NOTE: The issue will be resolved after deploying changes. The loadConfig function uses in portal, but related issue didn't reported, so loading proper config for scorecardClassic will be resolved after releasing portal.

Reference

Issue #2582

Testing

Locally in Reunite.
Ran test in monorepo with snapshot: https://github.com/Redocly/redocly/pull/21122

Screenshots (optional)

Check yourself

  • Code changed? - Tested with Redoc/Realm/Reunite (internal)
  • All new/updated code is covered by tests
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2026

🦋 Changeset detected

Latest commit: b189b51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch
@redocly/respect-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.62% (🎯 79%) 6372 / 8003
🔵 Statements 79.05% (🎯 78%) 6583 / 8327
🔵 Functions 83.53% (🎯 83%) 1309 / 1567
🔵 Branches 71.17% (🎯 71%) 4341 / 6099
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/cli/src/commands/scorecard-classic/remote/fetch-scorecard.ts 79.41% 70% 100% 79.41% 58-61, 72-75, 129-130, 162, 169-173
packages/core/src/config/visitors.ts 100% 100% 100% 100%
packages/core/src/types/redocly-yaml.ts 92.3% 82.85% 100% 91.93% 366-373, 375, 520-525, 528-533, 536-541
Generated in workflow #8752 for commit b189b51 by the Vitest Coverage Report Action

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

CLI Version Mean Time ± Std Dev (s) Relative Performance (Lower is Faster)
cli-latest 3.494s ± 0.028s ▓ 1.00x (Fastest)
cli-next 3.499s ± 0.022s ▓ 1.00x

@AlbinaBlazhko17 AlbinaBlazhko17 added the snapshot Create experimental release PR label Feb 20, 2026
@github-actions
Copy link
Contributor

📦 A new experimental 🧪 version v0.0.0-snapshot.1771584362 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/cli@0.0.0-snapshot.1771584362
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1771584362
# or
npm install @redocly/respect-core@0.0.0-snapshot.1771584362

⚠️ Note: This is a development build and may contain unstable features.

@AlbinaBlazhko17 AlbinaBlazhko17 marked this pull request as ready for review February 23, 2026 13:44
@AlbinaBlazhko17 AlbinaBlazhko17 requested review from a team as code owners February 23, 2026 13:44
Copy link
Collaborator

@tatomyr tatomyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The solution is temporal, I'm going to fix that in an upcoming PR.

@AlbinaBlazhko17 AlbinaBlazhko17 merged commit 3f94201 into main Feb 24, 2026
39 of 40 checks passed
@AlbinaBlazhko17 AlbinaBlazhko17 deleted the fix/scorecard-classic-not-resolving-plugins branch February 24, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshot Create experimental release PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants