Skip to content

chore: update benchmarks, coverage threshold; improve types and names#1781

Merged
Marshevskyy merged 1 commit intomainfrom
chore/update-benchmarks
Oct 25, 2024
Merged

chore: update benchmarks, coverage threshold; improve types and names#1781
Marshevskyy merged 1 commit intomainfrom
chore/update-benchmarks

Conversation

@tatomyr
Copy link
Collaborator

@tatomyr tatomyr commented Oct 22, 2024

What/Why/How?

Updated benchmarks with the recent CLI versions.
Adjusted the benchmark command.
Bumped code coverage threshold.
Improved types and naming.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 321e4d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 981.7 ± 30.4 956.2 1062.5 1.00 ± 0.03
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 979.7 ± 11.4 967.8 1004.3 1.00

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.58% 4993/6354
🟡 Branches 67.24% 2063/3068
🟡 Functions 73.01% 825/1130
🟡 Lines 78.87% 4711/5973

Test suite run success

810 tests passing in 121 suites.

Report generated by 🧪jest coverage report action from 321e4d2

@tatomyr tatomyr marked this pull request as ready for review October 22, 2024 13:09
@tatomyr tatomyr requested a review from a team as a code owner October 22, 2024 13:09
@Marshevskyy Marshevskyy merged commit d361240 into main Oct 25, 2024
@Marshevskyy Marshevskyy deleted the chore/update-benchmarks branch October 25, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants