Skip to content

Indicate source disposal in timeout(fallback) #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 1 commit into from
Jan 15, 2019
Merged

Indicate source disposal in timeout(fallback) #6365

akarnokd merged 1 commit into from
Jan 15, 2019

Conversation

@artem-zinnatullin
Copy link
Contributor

@artem-zinnatullin artem-zinnatullin commented Jan 14, 2019

Some of the overloads of timeout(…, fallback) operator didn't indicate that source gets disposed on timeout in the javadoc.

@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #6365 into 2.x will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6365      +/-   ##
============================================
- Coverage     98.26%   98.23%   -0.04%     
- Complexity     6286     6287       +1     
============================================
  Files           673      673              
  Lines         45021    45021              
  Branches       6224     6224              
============================================
- Hits          44242    44226      -16     
- Misses          246      257      +11     
- Partials        533      538       +5
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 567 <0> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 542 <0> (ø) ⬇️
src/main/java/io/reactivex/Maybe.java 100% <ø> (ø) 172 <0> (ø) ⬇️
...nternal/operators/observable/ObservableCreate.java 93.16% <0%> (-5.13%) 2% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 95.83% <0%> (-3.48%) 55% <0%> (-2%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 89.85% <0%> (-3.39%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-2.72%) 2% <0%> (ø)
...x/internal/operators/flowable/FlowablePublish.java 97.02% <0%> (-1.71%) 11% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-1.2%) 2% <0%> (ø)
...java/io/reactivex/processors/UnicastProcessor.java 98.8% <0%> (-1.2%) 67% <0%> (-1%)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7d0a33...58cad31. Read the comment docs.

@akarnokd akarnokd merged commit e1b3838 into ReactiveX:2.x Jan 15, 2019
@artem-zinnatullin artem-zinnatullin deleted the az/timeout-javadoc-dispose branch January 15, 2019 23:42
@akarnokd akarnokd mentioned this pull request Jan 16, 2019
Closed
@artem-zinnatullin artem-zinnatullin restored the az/timeout-javadoc-dispose branch August 16, 2019 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akarnokd akarnokd akarnokd approved these changes

+1 more reviewer

@vanniktech vanniktech vanniktech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.x Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artem-zinnatullin @akarnokd @vanniktech