Skip to content

2.x: Update README #6353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 1 commit into from
Jan 2, 2019
Merged

2.x: Update README #6353

akarnokd merged 1 commit into from
Jan 2, 2019

Conversation

@lorenzpahl
Copy link
Contributor

@lorenzpahl lorenzpahl commented Jan 2, 2019

This PR updates the Converting to the desired type section in the README to use Single::ignoreElement instead of Single::toCompletable to convert a Single to a Completable. The reason for that is that the Javadoc mentions that Single::toCompletable is considered deprecated and Single::ignoreElement should be used instead.

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #6353 into 2.x will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6353      +/-   ##
============================================
+ Coverage     98.21%   98.24%   +0.02%     
+ Complexity     6283     6282       -1     
============================================
  Files           672      672              
  Lines         44990    44990              
  Branches       6223     6223              
============================================
+ Hits          44189    44202      +13     
+ Misses          257      249       -8     
+ Partials        544      539       -5
Impacted Files Coverage Δ Complexity Δ
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...ava/io/reactivex/processors/BehaviorProcessor.java 96.86% <0%> (-2.25%) 60% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 97.43% <0%> (-1.71%) 2% <0%> (ø)
...tivex/internal/operators/single/SingleTimeout.java 98.33% <0%> (-1.67%) 2% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 95.83% <0%> (-1.39%) 55% <0%> (-1%)
...ernal/operators/flowable/FlowableFromIterable.java 95.18% <0%> (-1.07%) 5% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.36% <0%> (-1.07%) 9% <0%> (ø)
...operators/observable/ObservableMergeWithMaybe.java 99.1% <0%> (-0.9%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableTimeoutTimed.java 98.37% <0%> (-0.82%) 3% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 537fa26...43d4816. Read the comment docs.

@akarnokd akarnokd added this to the 2.2 backlog milestone Jan 2, 2019
@akarnokd akarnokd merged commit 2e0c8b5 into ReactiveX:2.x Jan 2, 2019
@lorenzpahl lorenzpahl deleted the docs/convert-single-to-completable branch January 2, 2019 17:25
@akarnokd akarnokd mentioned this pull request Jan 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akarnokd akarnokd akarnokd approved these changes

Assignees

No one assigned

Labels

2.x Documentation

Projects

None yet

Milestone

2.2 backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@lorenzpahl @akarnokd