Skip to content

Update outdated java example in wiki #6331 #6351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 3 commits into from
Dec 28, 2018
Merged

Update outdated java example in wiki #6331 #6351

akarnokd merged 3 commits into from
Dec 28, 2018

Conversation

@ozcanyus
Copy link
Contributor

@ozcanyus ozcanyus commented Dec 27, 2018 •
edited by akarnokd
Loading

Updated java example in docs/How-To-Use-RxJava.md file with java 8 version.

Resolves: #6331

@codecov
Copy link

codecov bot commented Dec 27, 2018 •
edited
Loading

Codecov Report

Merging #6351 into 2.x will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6351      +/-   ##
============================================
- Coverage     98.27%   98.22%   -0.06%     
- Complexity     6285     6286       +1     
============================================
  Files           672      672              
  Lines         44990    44990              
  Branches       6223     6223              
============================================
- Hits          44214    44191      -23     
- Misses          246      259      +13     
- Partials        530      540      +10
Impacted Files Coverage Δ Complexity Δ
...ex/internal/operators/flowable/FlowableCreate.java 90% <0%> (-6.46%) 6% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 90.84% <0%> (-3.93%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 94.87% <0%> (-3.42%) 2% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
...ex/internal/subscriptions/SubscriptionArbiter.java 97.47% <0%> (-2.53%) 50% <0%> (-1%)
...x/internal/operators/flowable/FlowablePublish.java 96.59% <0%> (-2.13%) 11% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.36% <0%> (-1.07%) 9% <0%> (ø)
...perators/mixed/ObservableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 3% <0%> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 96.93% <0%> (-1.03%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableTimeoutTimed.java 98.37% <0%> (-0.82%) 3% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aef7fe...8ea9869. Read the comment docs.

akarnokd
akarnokd reviewed Dec 27, 2018
View reviewed changes
docs/How-To-Use-RxJava.md Outdated
}

});
Observable.fromArray(names).subscribe(s -> System.out.println("Hello " + s));
Copy link
Member

@akarnokd akarnokd Dec 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd instead show a Consumer<String> and the lambda version, similar to the hello world example.

Copy link
Contributor Author

@ozcanyus ozcanyus Dec 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated similar to hello world example.

@akarnokd akarnokd added this to the 2.2 backlog milestone Dec 27, 2018
akarnokd
akarnokd requested changes Dec 27, 2018
View reviewed changes
@akarnokd akarnokd merged commit 4f0cdca into ReactiveX:2.x Dec 28, 2018
@akarnokd akarnokd mentioned this pull request Dec 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akarnokd akarnokd akarnokd approved these changes

+1 more reviewer

@vanniktech vanniktech vanniktech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.x Documentation

Projects

None yet

Milestone

2.2 backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@ozcanyus @akarnokd @vanniktech