Skip to content

2.x: Expose the Keep-Alive value of the IO Scheduler as System property. (#6279) #6287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 1 commit into from
Nov 5, 2018
Merged

2.x: Expose the Keep-Alive value of the IO Scheduler as System property. (#6279) #6287

akarnokd merged 1 commit into from
Nov 5, 2018

Conversation

@pawellozinski
Copy link
Contributor

@pawellozinski pawellozinski commented Nov 5, 2018 •
edited by akarnokd
Loading

Configuring Keep-Alive through System property.

Resolves: #6279

@akarnokd akarnokd added this to the 2.2 backlog milestone Nov 5, 2018
@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #6287 into 2.x will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6287      +/-   ##
============================================
+ Coverage     98.25%   98.29%   +0.03%     
+ Complexity     6262     6261       -1     
============================================
  Files           667      667              
  Lines         44888    44889       +1     
  Branches       6214     6214              
============================================
+ Hits          44105    44122      +17     
+ Misses          249      236      -13     
+ Partials        534      531       -3
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/schedulers/Schedulers.java 100% <ø> (ø) 10 <0> (ø) ⬇️
.../io/reactivex/internal/schedulers/IoScheduler.java 91.48% <100%> (+1.16%) 9 <0> (ø) ⬇️
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
...x/internal/operators/flowable/FlowablePublish.java 96.59% <0%> (-2.13%) 11% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 93.23% <0%> (-1.94%) 2% <0%> (ø)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...perators/mixed/ObservableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 3% <0%> (ø)
.../operators/mixed/FlowableConcatMapCompletable.java 99.14% <0%> (-0.86%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 97.43% <0%> (-0.86%) 2% <0%> (ø)
...vex/internal/operators/flowable/FlowableCache.java 97.72% <0%> (-0.76%) 37% <0%> (-1%)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3281b02...1fb3977. Read the comment docs.

@akarnokd akarnokd merged commit 6478312 into ReactiveX:2.x Nov 5, 2018
@akarnokd akarnokd mentioned this pull request Nov 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akarnokd akarnokd akarnokd approved these changes

+1 more reviewer

@vanniktech vanniktech vanniktech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.x Enhancement

Projects

None yet

Milestone

2.2 backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@pawellozinski @akarnokd @vanniktech