Skip to content

2.x: Cleanup Observable.flatMap drain logic #6232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 1 commit into from
Sep 30, 2018
Merged

2.x: Cleanup Observable.flatMap drain logic #6232

akarnokd merged 1 commit into from
Sep 30, 2018

Conversation

@akarnokd
Copy link
Member

@akarnokd akarnokd commented Sep 30, 2018

Cleanup the drain logic of Observable.flatMap by removing unnecessary loops and fixing the index management in case of a fused failure in one of the sources triggering another round over the same source unnecessarily.

Resolves: #6231

@akarnokd akarnokd added this to the 2.2 backlog milestone Sep 30, 2018
@codecov
Copy link

codecov bot commented Sep 30, 2018

Codecov Report

Merging #6232 into 2.x will increase coverage by 0.03%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6232      +/-   ##
============================================
+ Coverage     98.22%   98.26%   +0.03%     
+ Complexity     6202     6201       -1     
============================================
  Files           667      667              
  Lines         44888    44883       -5     
  Branches       6218     6216       -2     
============================================
+ Hits          44093    44104      +11     
+ Misses          256      241      -15     
+ Partials        539      538       -1
Impacted Files Coverage Δ Complexity Δ
...ternal/operators/observable/ObservableFlatMap.java 88.63% <55.55%> (+0.77%) 3 <0> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-3.81%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 93.46% <0%> (-1.97%) 2% <0%> (ø)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...internal/operators/flowable/FlowableFromArray.java 94.91% <0%> (-1.7%) 3% <0%> (ø)
...ternal/operators/flowable/FlowableSubscribeOn.java 96.61% <0%> (-1.7%) 2% <0%> (ø)
...ivex/internal/operators/maybe/MaybeMergeArray.java 96.62% <0%> (-1.13%) 6% <0%> (ø)
...l/operators/observable/ObservableTimeoutTimed.java 99.15% <0%> (-0.85%) 3% <0%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd48d56...2de431f. Read the comment docs.

@akarnokd akarnokd merged commit 1ea1e2a into ReactiveX:2.x Sep 30, 2018
@akarnokd akarnokd deleted the ObservableFlatMapCleanup branch September 30, 2018 09:38
@akarnokd akarnokd mentioned this pull request Oct 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vanniktech vanniktech vanniktech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.x Cleanup

Projects

None yet

Milestone

2.2 backlog

Development

Successfully merging this pull request may close these issues.

Value always true

2 participants

@akarnokd @vanniktech