Skip to content

2.x JavaDocs: Remove unnecessary 's' from ConnectableObservable #6220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 1 commit into from
Sep 21, 2018
Merged

2.x JavaDocs: Remove unnecessary 's' from ConnectableObservable #6220

akarnokd merged 1 commit into from
Sep 21, 2018

Conversation

@akarnokd
Copy link
Member

@akarnokd akarnokd commented Sep 21, 2018

Remove the unnecessary 's' from the JavaDocs of ConnectableObservable.autoConnect.

@akarnokd akarnokd added this to the 2.2 backlog milestone Sep 21, 2018
@codecov
Copy link

codecov bot commented Sep 21, 2018

Codecov Report

Merging #6220 into 2.x will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                2.x   #6220      +/-   ##
===========================================
- Coverage     98.22%   98.2%   -0.03%     
- Complexity     6199    6202       +3     
===========================================
  Files           667     667              
  Lines         44888   44888              
  Branches       6218    6218              
===========================================
- Hits          44092   44083       -9     
- Misses          252     258       +6     
- Partials        544     547       +3
Impacted Files Coverage Δ Complexity Δ
...o/reactivex/observables/ConnectableObservable.java 100% <ø> (ø) 12 <0> (ø) ⬇️
...ernal/operators/flowable/FlowableFromIterable.java 94.11% <0%> (-3.21%) 5% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 95.96% <0%> (-3.14%) 59% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-2.72%) 2% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 93.61% <0%> (-2.66%) 3% <0%> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
.../operators/mixed/FlowableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 2% <0%> (ø)
...operators/observable/ObservableMergeWithMaybe.java 99.1% <0%> (-0.9%) 2% <0%> (ø)
.../operators/maybe/MaybeFlatMapIterableFlowable.java 97.54% <0%> (-0.82%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 94.89% <0%> (-0.73%) 2% <0%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c00a8...ddf541f. Read the comment docs.

@akarnokd akarnokd merged commit 3c773ca into ReactiveX:2.x Sep 21, 2018
@akarnokd akarnokd deleted the JavadocFix921 branch September 21, 2018 18:13
@akarnokd akarnokd mentioned this pull request Oct 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vanniktech vanniktech vanniktech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.x Cleanup Documentation

Projects

None yet

Milestone

2.2 backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@akarnokd @vanniktech