Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ReactiveX/RxJava
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.2.8
Choose a base ref
...
head repository: ReactiveX/RxJava
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.2.9
Choose a head ref
  • 11 commits
  • 19 files changed
  • 8 contributors

Commits on Apr 4, 2019

  1. Remove dependency of Schedulers from ObservableRefCount (#6452)

    In the constructor of `ObservableRefCount` that takes `ConnectableObservable<T> source` as the argument, we set `timeout` to `0L`. In that specific use case of `ObservableRefCount`, `scheduler` is never needed. It's only referenced in `cancel()` method but if timeout is 0, it won't be triggered at all because there is early return. This commit removes the need to depend on `Schedulers.trampoline()` and instead passes null to be scheduler when the ref count is not time-based.
    
    The reasons for this change are the following:
    
    1. In projects that don't depend on `Schedulers` class, if there is no reference to `Schedulers`, the whole `Schedulers` can be stripped out of the library after optimizations (e.g., proguard). With constructor that references `Schedulers`, the optimizer can't properly strip it out. In our quick test of our Android app, we were able to reduce the RxJava library size dependency from 51KB to 37KB (after optimization but before compression) by simply avoiding access to `Schedulers` in `ObservableRefCount`.
    2. In terms of modularity, `ObservableRefCount` is just an operator so it by itself should probably not have dependency on what available pool of schedulers (`Schedulers`) there are. It should just know that there is some `Scheduler` that could be passed to `ObservableRefCount` when `ObservableRefCount` needs it.
    mycallmax authored and akarnokd committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    0f565f2 View commit details
    Browse the repository at this point in the history
  2. Fixed typos for comments (#6453)

    * Update Maybe.java
    
    * Update Single.java
    lxsmnsyc authored and akarnokd committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    3958d1b View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Update the Javadoc of the retry operator (#6458)

    Specify that the `times` function parameter describes "the number of times
    to resubscribe if the current *operator* fails".
    
    Also, this commit updates some unit tests to illustrate the Javadoc wording.
    
    Solves: #6402
    RomanWuattier authored and akarnokd committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    c04cfb8 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2019

  1. Change error message in ObservableFromArray (#6461)

    * Change error message in ObservableFromArray
    
    Changed error message from "The $i th element is null" to "The element at index $i is null".
    
    Solves #6460
    
    * Change error messages in FlowableFromArray
    
    Changed error messages from "array element is null" to "The element at index $i is null".
    
    Solves #6460
    iruizm authored and akarnokd committed Apr 13, 2019
    Configuration menu
    Copy the full SHA
    deeb141 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2019

  1. Remove redundant methods from Sample(Observable) (#6469)

    * Update Maybe.java
    
    * Update Single.java
    
    * Update ObservableSampleWithObservable.java
    
    * Update FlowableSamplePublisher.java
    
    * Update FlowableSamplePublisher.java
    lxsmnsyc authored and akarnokd committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    b570c91 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2019

  1. Configuration menu
    Copy the full SHA
    ac84182 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2019

  1. Update README.md (#6480)

    fix issue #6479
    cvgaviao authored and akarnokd committed May 18, 2019
    Configuration menu
    Copy the full SHA
    1830453 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2019

  1. Correction for Maybe.count doc typo (#6483)

    Resolves #6481
    lxsmnsyc authored and akarnokd committed May 20, 2019
    Configuration menu
    Copy the full SHA
    8f51d2d View commit details
    Browse the repository at this point in the history

Commits on May 23, 2019

  1. remove unused else from the Observable (#6485)

    * remove unused else from the Observable
    
    * fixed MR comments
    VovaStelmashchuk authored and akarnokd committed May 23, 2019
    Configuration menu
    Copy the full SHA
    4ca7a9b View commit details
    Browse the repository at this point in the history

Commits on May 27, 2019

  1. Configuration menu
    Copy the full SHA
    c415b32 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2019

  1. Release 2.2.9

    akarnokd authored May 30, 2019
    Configuration menu
    Copy the full SHA
    86048e1 View commit details
    Browse the repository at this point in the history
Loading