-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Comparing changes
Open a pull request
base repository: ReactiveX/RxJava
base: v2.2.8
head repository: ReactiveX/RxJava
compare: v2.2.9
- 11 commits
- 19 files changed
- 8 contributors
Commits on Apr 4, 2019
-
Remove dependency of Schedulers from ObservableRefCount (#6452)
In the constructor of `ObservableRefCount` that takes `ConnectableObservable<T> source` as the argument, we set `timeout` to `0L`. In that specific use case of `ObservableRefCount`, `scheduler` is never needed. It's only referenced in `cancel()` method but if timeout is 0, it won't be triggered at all because there is early return. This commit removes the need to depend on `Schedulers.trampoline()` and instead passes null to be scheduler when the ref count is not time-based. The reasons for this change are the following: 1. In projects that don't depend on `Schedulers` class, if there is no reference to `Schedulers`, the whole `Schedulers` can be stripped out of the library after optimizations (e.g., proguard). With constructor that references `Schedulers`, the optimizer can't properly strip it out. In our quick test of our Android app, we were able to reduce the RxJava library size dependency from 51KB to 37KB (after optimization but before compression) by simply avoiding access to `Schedulers` in `ObservableRefCount`. 2. In terms of modularity, `ObservableRefCount` is just an operator so it by itself should probably not have dependency on what available pool of schedulers (`Schedulers`) there are. It should just know that there is some `Scheduler` that could be passed to `ObservableRefCount` when `ObservableRefCount` needs it.
Configuration menu - View commit details
-
Copy full SHA for 0f565f2 - Browse repository at this point
Copy the full SHA 0f565f2View commit details -
Fixed typos for comments (#6453)
* Update Maybe.java * Update Single.java
Configuration menu - View commit details
-
Copy full SHA for 3958d1b - Browse repository at this point
Copy the full SHA 3958d1bView commit details
Commits on Apr 12, 2019
-
Update the Javadoc of the
retryoperator (#6458)Specify that the `times` function parameter describes "the number of times to resubscribe if the current *operator* fails". Also, this commit updates some unit tests to illustrate the Javadoc wording. Solves: #6402
Configuration menu - View commit details
-
Copy full SHA for c04cfb8 - Browse repository at this point
Copy the full SHA c04cfb8View commit details
Commits on Apr 13, 2019
-
Configuration menu - View commit details
-
Copy full SHA for deeb141 - Browse repository at this point
Copy the full SHA deeb141View commit details
Commits on Apr 26, 2019
-
Remove redundant methods from Sample(Observable) (#6469)
* Update Maybe.java * Update Single.java * Update ObservableSampleWithObservable.java * Update FlowableSamplePublisher.java * Update FlowableSamplePublisher.java
Configuration menu - View commit details
-
Copy full SHA for b570c91 - Browse repository at this point
Copy the full SHA b570c91View commit details
Commits on Apr 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ac84182 - Browse repository at this point
Copy the full SHA ac84182View commit details
Commits on May 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 1830453 - Browse repository at this point
Copy the full SHA 1830453View commit details
Commits on May 20, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8f51d2d - Browse repository at this point
Copy the full SHA 8f51d2dView commit details
Commits on May 23, 2019
-
remove unused else from the Observable (#6485)
* remove unused else from the Observable * fixed MR comments
Configuration menu - View commit details
-
Copy full SHA for 4ca7a9b - Browse repository at this point
Copy the full SHA 4ca7a9bView commit details
Commits on May 27, 2019
-
Configuration menu - View commit details
-
Copy full SHA for c415b32 - Browse repository at this point
Copy the full SHA c415b32View commit details
Commits on May 30, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 86048e1 - Browse repository at this point
Copy the full SHA 86048e1View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.2.8...v2.2.9