Support data-tooltip-class-name on anchor elements#1132
Merged
gabrieljablonski merged 1 commit intoReactTooltip:masterfrom Dec 4, 2023
Merged
Support data-tooltip-class-name on anchor elements#1132gabrieljablonski merged 1 commit intoReactTooltip:masterfrom
gabrieljablonski merged 1 commit intoReactTooltip:masterfrom
Conversation
Member
|
Thanks for taking the time, everything looks good on the first pass, will be testing and reviewing properly later. And yes, our workflows are a bit broken right now, including testing, so don't worry about that. |
gabrieljablonski
approved these changes
Dec 4, 2023
Member
gabrieljablonski
left a comment
There was a problem hiding this comment.
Everything looks good, no changes needed.
As for the test, we're already planning on reviewing all test cases to fix some inconsistencies, so no need to worry about it passing right now.
danielbarion
approved these changes
Dec 4, 2023
Closed
Contributor
Author
|
Should I be targeting the v6 branch? |
Member
|
@fatton139 we are still working on a roadmap for the V6 and we don't have a release date for it yet, I believe this PR is good to go on V5, thanks for checking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the discussion here: #1129 (reply in thread)
Support
data-tooltip-class-nameon anchor elements for injection into the tooltip container.The tests doesn't look to be passing.