Skip to content

Changeable role attribute#1124

Merged
gabrieljablonski merged 4 commits intoReactTooltip:masterfrom
mailinhdang:feat/changeable-role-attribute
Nov 21, 2023
Merged

Changeable role attribute#1124
gabrieljablonski merged 4 commits intoReactTooltip:masterfrom
mailinhdang:feat/changeable-role-attribute

Conversation

@mailinhdang
Copy link

Closes #1123.

Copy link
Member

@gabrieljablonski gabrieljablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the generic AriaRole type should cover all other possible cases, not only the dialog alternative.

@mailinhdang
Copy link
Author

I committed a change with the generic type AriaRole :)
Was thinking about using it before but thought it would be too generic and open for misuse but it's certainly more flexible.

@danielbarion
Copy link
Member

Looks great!

Thanks for the contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT REQ] Changeable role attribute (v5)

4 participants