Skip to content

fix: duplicated preload bundles in SSR preload#8248

Merged
wmertens merged 1 commit intoQwikDev:mainfrom
chebanenko:remove-dublicated-preloaded-chunks
Jan 19, 2026
Merged

fix: duplicated preload bundles in SSR preload#8248
wmertens merged 1 commit intoQwikDev:mainfrom
chebanenko:remove-dublicated-preloaded-chunks

Conversation

@chebanenko
Copy link
Copy Markdown

@chebanenko chebanenko commented Jan 17, 2026

What is it?

  • Bug

Description

Removes duplication of the preload bundles in the preload script. Seems like resolves issue: #8244

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 17, 2026

🦋 Changeset detected

Latest commit: b74ac2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
@builder.io/qwik-react Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Jan 17, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@8248

npm i https://pkg.pr.new/@builder.io/qwik-city@8248

npm i https://pkg.pr.new/eslint-plugin-qwik@8248

npm i https://pkg.pr.new/create-qwik@8248

commit: b74ac2c

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 17, 2026 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview b74ac2c

@Varixo Varixo requested a review from wmertens January 17, 2026 19:29
@wmertens
Copy link
Copy Markdown
Member

wmertens commented Jan 18, 2026

@chebanenko LGTM, why is it still in draft?

wmertens
wmertens approved these changes Jan 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎩

@chebanenko chebanenko marked this pull request as ready for review January 19, 2026 08:55
@chebanenko chebanenko requested a review from a team as a code owner January 19, 2026 08:55
@chebanenko
Copy link
Copy Markdown
Author

chebanenko commented Jan 19, 2026

@wmertens oh, my fault. Ready from now.

@wmertens wmertens merged commit bf02edb into QwikDev:main Jan 19, 2026
21 checks passed
gioboa
gioboa reviewed Jan 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chebanenko for your help 👏

@github-actions github-actions bot mentioned this pull request Jan 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gioboa gioboa gioboa left review comments

@wmertens wmertens wmertens approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chebanenko @wmertens @gioboa