Skip to content

perf: remove unregister events in qwikloader#7818

Merged
wmertens merged 2 commits intomainfrom
remove-settimeout-qwikloader
Aug 13, 2025
Merged

perf: remove unregister events in qwikloader#7818
wmertens merged 2 commits intomainfrom
remove-settimeout-qwikloader

Conversation

@Varixo
Copy link
Member

@Varixo Varixo commented Aug 13, 2025

remove a grace period before unregistering events from qwikloader due to perf issues

@Varixo Varixo self-assigned this Aug 13, 2025
@Varixo Varixo requested a review from a team as a code owner August 13, 2025 16:37
@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2025

🦋 Changeset detected

Latest commit: 116e0be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for context: this was causing a slowdown on new DOM element creation

LGTM

@wmertens wmertens enabled auto-merge August 13, 2025 16:42
@wmertens wmertens merged commit 23b917f into main Aug 13, 2025
23 checks passed
@wmertens wmertens deleted the remove-settimeout-qwikloader branch August 13, 2025 20:54
@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 13, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7818
npm i https://pkg.pr.new/@builder.io/qwik-city@7818
npm i https://pkg.pr.new/eslint-plugin-qwik@7818
npm i https://pkg.pr.new/create-qwik@7818

commit: 116e0be

@github-actions github-actions bot mentioned this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants